Improvements

.github/workflows/ci.yml

@@ -22,7 +22,6 @@ jobs:
     strategy:
       matrix:
         node-version: 
-          - 18.x
           - 20.x
           - 22.x
 

.gitignore

@@ -1,6 +1,7 @@
 # Built code
 dist
 lib
+dist-dev
 src/versionInfo.ts
 
 # Logs

babel.config.js

@@ -0,0 +1,15 @@
+export default {
+  presets: [
+    ['@babel/preset-env', { targets: { node: 'current' } }],
+    '@babel/preset-typescript'
+  ],
+  plugins: [
+    [
+      'babel-plugin-inline-import', {
+        extensions: [
+          '.ttl'
+        ]
+      }
+    ]
+  ]
+}

eslint.config.mjs

@@ -1,34 +1,92 @@
-import typescriptEslint from "@typescript-eslint/eslint-plugin";
-import globals from "globals";
-import tsParser from "@typescript-eslint/parser";
+import tseslintPlugin from '@typescript-eslint/eslint-plugin'
+import globals from 'globals'
+import tsParser from '@typescript-eslint/parser'
+import neostandard from 'neostandard'
 
-export default [{
-    ignores: ["**/dist", "**/lib", "typings/rdflib"],
-}, {
+export default [
+  ...neostandard(),
+  {
+    ignores: [
+      'dist/**',
+      'lib/**',
+      'docs/**',
+      'node_modules/**',
+      'dev/**',
+      'dev-dist/**',
+      'coverage/**',
+    ],
+  },
+  {
+    files: ['src/**/*.js', 'src/**/*.cjs', 'src/**/*.mjs'],
+    languageOptions: {
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+        Atomics: 'readonly',
+        SharedArrayBuffer: 'readonly',
+      }
+    },
+    rules: {
+      semi: ['error', 'never'],
+      quotes: ['error', 'single'],
+      'no-unused-vars': 'off', // handled by TS
+    }
+  },
+  {
+    files: ['src/**/*.ts'],
     plugins: {
-        "@typescript-eslint": typescriptEslint,
+      '@typescript-eslint': tseslintPlugin,
     },
 
     languageOptions: {
-        globals: {
-            ...globals.browser,
-            ...globals.node,
-            Atomics: "readonly",
-            SharedArrayBuffer: "readonly",
-        },
-
-        parser: tsParser,
+      globals: {
+        ...globals.browser,
+        ...globals.node,
+        Atomics: 'readonly',
+        SharedArrayBuffer: 'readonly',
+      },
+      parser: tsParser,
+      parserOptions: {
+        project: ['./tsconfig.json']
+      },
     },
-    files: ["src/**/*.js", "src/**/*.ts", "src/**/*.cjs", "src/**/*.mjs"],
     rules: {
-        "no-unused-vars": ["warn", {
-            argsIgnorePattern: "^_",
-            varsIgnorePattern: "^_",
-        }],
-
-        "@typescript-eslint/no-unused-vars": ["warn", {
-            argsIgnorePattern: "^_",
-            varsIgnorePattern: "^_",
-        }],
+      semi: ['error', 'never'],
+      quotes: ['error', 'single'],
+      'no-console': 'warn',
+      'no-unused-vars': 'off',
+      '@typescript-eslint/no-unused-vars': ['warn', {
+        argsIgnorePattern: '^_',
+        varsIgnorePattern: '^_',
+      }],
+      // '@typescript-eslint/no-explicit-any': 'warn', - codebase not ready for this
     },
-}];
+  },
+  {
+    files: ['test/**/*.ts'],
+    plugins: {
+      '@typescript-eslint': tseslintPlugin,
+    },
+    languageOptions: {
+      parser: tsParser,
+      parserOptions: {
+        project: ['./tsconfig.test.json'],
+      },
+    },
+    rules: {
+      semi: ['error', 'never'],
+      quotes: ['error', 'single'],
+      'no-console': 'off', // Allow console in tests
+      'no-undef': 'off', // Tests may define globals
+    }
+  },
+  {
+    files: ['test/**/**/*.js', 'test/**/*.js'],
+    rules: {
+      semi: ['error', 'never'],
+      quotes: ['error', 'single'],
+      'no-console': 'off', // Allow console in tests
+      'no-undef': 'off', // Tests may define globals
+    }
+  }
+]

jest.config.js

@@ -1,27 +1,32 @@
-module.exports = {
+export default {
+  collectCoverage: true,
+  coverageDirectory: 'coverage',
   preset: 'ts-jest/presets/js-with-babel',
   testEnvironment: 'jsdom',
   testEnvironmentOptions: {
     customExportConditions: ['node']
   },
-  moduleNameMapper: {
-    '^[./a-zA-Z0-9$_-]+\\.ttl$': '<rootDir>/__mocks__/fileMock.js',    // '\\.ttl$'
+  testPathIgnorePatterns: ['/node_modules/', '/dist/'],
+  transform: {
+    '^.+\\.[tj]sx?$': ['babel-jest', { configFile: './babel.config.js' }],
   },
-  collectCoverage: true,
+  transformIgnorePatterns: ['/node_modules/(?!lit-html).+\\.js'],
+  setupFilesAfterEnv: ['./test/helpers/setup.ts'],
+  testMatch: ['**/?(*.)+(spec|test).[tj]s?(x)'],
+  roots: ['<rootDir>/src', '<rootDir>/test'],
   // For some reason Jest is not measuring coverage without the below option.
   // Unfortunately, despite `!(.test)`, it still measures coverage of test files as well:
-  forceCoverageMatch: ['./src/**/*!(.test).ts'],
+  // forceCoverageMatch: ['./src/**/*!(.test).ts'],
   // Since we're only measuring coverage for TypeScript (i.e. added with test infrastructure in place),
   // we can be fairly strict. However, if you feel that something is not fit for coverage,
   // mention why in a comment and mark it as ignored:
   // https://github.com/gotwarlost/istanbul/blob/master/ignoring-code-for-coverage.md
-  coverageThreshold: {
+  /* coverageThreshold: {
     global: {
       branches: 10,
       functions: 25,
       lines: 20,
       statements: 20
     }
-  },
-  setupFilesAfterEnv: ['./jest.setup.ts']
+  } */
 }