SCANPY-164 Allow the use of kebab cases for all properties in pyproject.toml #181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guillaume-dequenne
force-pushed
the
SCANPY-164
branch
from
a8a8095 to
60662b1
Compare
Seppli11
approved these changes
Apr 1, 2025
Contributor
Seppli11
left a comment
Seppli11
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the change
It might make sense to split the look up and camel case conversion, so a debug log message could be added into between. This would make it more apparent to the user (at least in debug mode) that the conversion is going on.
guillaume-dequenne
force-pushed
the
SCANPY-164
branch
3 times, most recently
from
68f3614 to
d2d7fd8
Compare
guillaume-dequenne
force-pushed
the
SCANPY-164
branch
from
d2d7fd8 to
e569d91
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SCANPY-164