-
Notifications
You must be signed in to change notification settings - Fork 4
SCANPY-214: Change property name --sonar-cpd-python-minimum-tokens to --sonar-cpd-py-minimum-tokens #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… --sonar-cpd-py-minimum-tokens
Seppli11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change itself looks good. However, this would be a breaking change.
As such, I think it would make sense to keep both --sonar-cpd-py-minimum-lines and --sonar-cpd-python-minimum-lines (the same applies for the minimum tokens).
This would still be a breaking change for the environment variable parsing, but I feel like we could live with that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the quick fix.
I think we don't need the -D... args, since they just act as documentation.
(Sorry, I probably could have been a bit clearer in my review)
| "--sonar-cpd-py-minimum-lines", | ||
| "-Dsonar.cpd.py.minimumLines", | ||
| "--sonar-cpd-python-minimum-lines", | ||
| "-Dsonar.cpd.python.minimumLines", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The -Dsonar.cpd.python.minimumLines we shouldn't need, since any non-consumed parameter beginning with -D... will be passed along.
Same applies for minimum tokens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should keep them as we will pass the property to the correct sonar.cpd.py....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. I think the PR can be merged then
|




SCANPY-214
Part of