Skip to content

Conversation

@nquinquenel
Copy link
Member

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Clean up proxied servers logic MCP-281 Clean up proxied servers logic Feb 9, 2026
@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Feb 9, 2026

MCP-281

@nquinquenel nquinquenel force-pushed the task/nq/cleanup-proxied branch 2 times, most recently from cdbdc0f to a55fa16 Compare February 9, 2026 12:19
@nquinquenel nquinquenel force-pushed the task/nq/cleanup-proxied branch from a55fa16 to 8eabaad Compare February 10, 2026 18:24
@sonarqubecloud
Copy link

SonarQube reviewer guide

Review in SonarQube

Summary: Update tool namespacing from forward slash to underscore separator, add stderr logging for proxied servers, increase default timeout, and improve argument filtering for proxied tool execution.

Review Focus:

  • The namespacing change from / to _ is a breaking change affecting tool naming across the codebase—verify all references are updated consistently.
  • The new stderr handler in McpClientManager captures diagnostic logs; ensure the logging pattern [serverName] doesn't conflict with existing log formats.
  • The Tool.toMap() filtering of null values and ctx parameter is critical for proxied server communication—confirm this doesn't break any expected argument forwarding.
  • Timeout increase from 30s to 60s and initialization timeout addition of 1 minute should be validated against real proxied server startup times.

Start review at: src/main/java/org/sonarsource/sonarqube/mcp/client/McpClientManager.java. This is the core logic handling proxied server communication, stderr logging setup, and tool name construction. The changes here directly impact how proxied tools are exposed and how diagnostic information flows back to users.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
88.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant