Skip to content

Conversation

@nquinquenel
Copy link
Member

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod bot changed the title Setup CAG MCP-282 Setup CAG Feb 9, 2026
@hashicorp-vault-sonar-prod
Copy link

hashicorp-vault-sonar-prod bot commented Feb 9, 2026

MCP-282

@nquinquenel nquinquenel force-pushed the task/nq/cleanup-proxied branch from 0586b09 to cdbdc0f Compare February 9, 2026 12:14
@nquinquenel nquinquenel force-pushed the task/nq/cleanup-proxied branch from cdbdc0f to a55fa16 Compare February 9, 2026 12:19
@nquinquenel nquinquenel force-pushed the poc/nq/cag-setup branch 2 times, most recently from 606eaee to e5e93ca Compare February 10, 2026 18:20
@nquinquenel nquinquenel force-pushed the task/nq/cleanup-proxied branch from a55fa16 to 8eabaad Compare February 10, 2026 18:24
@sonarqubecloud
Copy link

SonarQube reviewer guide

Review in SonarQube

Summary:
Refactor proxied MCP server tool integration to remove namespace prefixing, improve process lifecycle management, and enhance log level parsing from proxied servers.

Review Focus:

  1. ManagedStdioClientTransport - New process lifecycle management with timeout-based termination and forcible cleanup; critical for proper Docker shutdown behavior
  2. Tool naming removal - Namespace prefixes removed from proxied tool names; verify this doesn't break existing tool references
  3. Log level parsing - New logic to detect and preserve log levels from stderr; check regex patterns and default behavior
  4. PROJECTS toolset change - No longer always enabled; confirm this doesn't break required project lookups

Start review at: src/main/java/org/sonarsource/sonarqube/mcp/client/ManagedStdioClientTransport.java. This new transport implementation is foundational to the PR and handles critical process cleanup that prevents zombie processes on container shutdown. Its correctness directly impacts production reliability.

💬 Please send your feedback

Quality Gate Passed Quality Gate passed

Issues
0 New issues
10 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
80.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant