MCP-274 Handle HTTP Responses Better

[eray-felek-sonarsource]

No description provided.

[hashicorp-vault-sonar-prod]

MCP-274

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues
0 Dependency risks

Measures
0 Security Hotspots
90.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[Copilot]

Pull request overview

Improve error handling for HTTP responses by extracting useful messages from JSON error bodies and making response body parsing more resilient.

Changes:

• Extend JSON error parsing to support a top-level message field when errors is absent.
• Add a fallback in HttpResponse.bodyAsString() to decode body bytes when text is unavailable.
• Add tests covering these new behaviors.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
src/main/java/org/sonarsource/sonarqube/mcp/serverapi/ServerApiHelper.java	Parse message from JSON error bodies when errors is missing
src/main/java/org/sonarsource/sonarqube/mcp/http/HttpResponse.java	Fallback from getBodyText() to UTF-8 decoded getBodyBytes()
src/test/java/org/sonarsource/sonarqube/mcp/serverapi/ServerApiTests.java	Tests for message parsing and ignoring irrelevant JSON bodies
src/test/java/org/sonarsource/sonarqube/mcp/http/HttpClientProviderTests.java	Test for bodyAsString() fallback when getBodyText() is null

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

JsonObject#getAsJsonPrimitive("message") can throw if message exists but is not a JSON primitive (e.g., null, object, array). To make this robust, fetch via obj.get("message") and only read it when the element is a non-null primitive (e.g., element != null && element.isJsonPrimitive() && !element.isJsonNull()).

Suggested change

	var message = obj.getAsJsonPrimitive("message");
	if (message != null) {
	return message.getAsString();
	JsonElement messageElement = obj.get("message");
	if (messageElement != null && messageElement.isJsonPrimitive() && !messageElement.isJsonNull()) {
	return messageElement.getAsJsonPrimitive().getAsString();

[nquinquenel]

Seems like a valid consideration