Skip to content

Add failure reason argument for after_failed_login callback #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add failure reason argument for after_failed_login callback #175

wants to merge 1 commit into from

Conversation

songhuangcn
Copy link

Follow #41, maybe we need the failure reason in callbacks

joshbuker
joshbuker previously requested changes Mar 16, 2019
View reviewed changes
@joshbuker joshbuker mentioned this pull request May 27, 2021
Open
@joshbuker joshbuker added the to be implemented in v1 This issue or pull request will be resolved in the v1 rework, but has not yet been completed. label May 27, 2021
@joshbuker joshbuker dismissed their stale review May 27, 2021 04:43

No longer relevant

@joshbuker
Copy link
Member

@songhuangcn The failure_reason is being expanded to be :status due to the addition of MFA in the near future, but I think it's pretty reasonable to pass the status to any login-related callbacks. I'll get this added to v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshbuker joshbuker joshbuker left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
to be implemented in v1 This issue or pull request will be resolved in the v1 rework, but has not yet been completed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@songhuangcn @joshbuker