Skip to content

Conversation

@willnet
Copy link
Member

@willnet willnet commented Sep 29, 2025

Previously used domains like "blabla.com", "bla.com", and "bar.com" could exist in reality. Since IANA reserves example.com for documentation and examples, I replaced them with example.com whenever possible.

The exception is test.host, which Rails uses as the default domain in tests (see: https://github.com/rails/rails/blob/d09c4bbfcadcd6b3af847a11608a63c0718158ed/actionpack/lib/action_dispatch/testing/test_request.rb#L11). Simply changing it to example.com causes tests to fail. While adding the following snippet to spec_helper.rb would make the tests pass, I decided to leave it as is since the motivation isn’t strong enough:

config.before(:each, type: :controller) do
  request.host = 'example.com'
end

related url: #387 (comment)

Previously used domains like "blabla.com", "bla.com", and "bar.com" could exist in reality. Since IANA reserves example.com for documentation and examples, I replaced them with example.com whenever possible.

The exception is test.host, which Rails uses as the default domain in tests (see: https://github.com/rails/rails/blob/d09c4bbfcadcd6b3af847a11608a63c0718158ed/actionpack/lib/action_dispatch/testing/test_request.rb#L11). Simply changing it to example.com causes tests to fail. While adding the following snippet to `spec_helper.rb` would make the tests pass, I decided to leave it as is since the motivation isn’t strong enough:

```ruby
config.before(:each, type: :controller) do
  request.host = 'example.com'
end
```

related url: Sorcery#387 (comment)
@willnet willnet requested review from a team and Copilot September 30, 2025 06:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces test domains with IANA-reserved "example.com" domains to follow best practices for test data. Previously used domains like "blabla.com", "bla.com", and "bar.com" could potentially exist in reality, while example.com is officially reserved for documentation and testing purposes.

  • Replaces potentially real domains with example.com in test files
  • Updates OAuth callback URLs to use example.com
  • Standardizes test email addresses to use example.com domain

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
spec/shared_examples/user_shared_examples.rb Updates test email addresses from potentially real domains to example.com
spec/shared_examples/user_oauth_shared_examples.rb Changes OAuth callback URL from blabla.com to example.com
spec/shared_examples/user_brute_force_protection_shared_examples.rb Updates authentication test email to use example.com
spec/controllers/controller_spec.rb Replaces test email addresses in controller specs with example.com
spec/controllers/controller_session_timeout_spec.rb Updates login test emails to use example.com domain
spec/controllers/controller_remember_me_spec.rb Changes test email addresses to example.com in remember me functionality tests
spec/controllers/controller_oauth_spec.rb Updates OAuth configuration URLs and test data to use example.com subdomains
spec/controllers/controller_oauth2_spec.rb Replaces OAuth2 callback URLs and test data with example.com variants
spec/controllers/controller_http_basic_auth_spec.rb Updates HTTP basic auth test email to example.com
spec/controllers/controller_brute_force_protection_spec.rb Changes brute force protection test email to example.com
lib/sorcery/test_helpers/internal.rb Updates default test user email in helper methods to example.com

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@brendon brendon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@willnet willnet merged commit 497d3c4 into Sorcery:master Oct 1, 2025
10 checks passed
@willnet willnet deleted the example-com branch October 1, 2025 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants