Skip to content

add delegateAdd and delegateRemove propeties so as to be able to ... #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add delegateAdd and delegateRemove propeties so as to be able to ... #28

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ad265d
add delegateAdd and delegateRemove propeties so as to be able to dela…
christophe-g Dec 9, 2016
0ab3618
Merge branch 'master' into delegateTemplate
christophe-g Jun 1, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions polymer-sortablejs.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,23 @@
fallbackClass : { type: String, value: "sortable-fallback", observer: "fallbackClassChanged" },
fallbackOnBody : { type: Boolean, value: false, observer: "fallbackOnBodyChanged" },
draggable : {},
scroll : {}
scroll : {},

/**
* `delegateAdd` set true to delegate adding item to the template to other part of the application
*/
delegateAdd: {
type: Boolean,
value: false
},

/**
* `delegateAdd` set true to delegate removing item to the template to other part of the application
*/
delegateRemove: {
type: Boolean,
value: false
}
},

created: function() {
Expand Down Expand Up @@ -79,19 +95,19 @@
onUpdate: function (e) {
if (template) {
template.splice("items", e.newIndex, 0, template.splice("items", e.oldIndex, 1)[0]);
/*
/*
if (manuallyHandleUpdateEvents) {
template.items.splice(e.newIndex, 0, template.items.splice(e.oldIndex, 1)[0]);
} else {
template.splice("items", e.newIndex, 0, template.splice("items", e.oldIndex, 1)[0]);
}
*/
*/
}
_this.fire("update", e);
},

onAdd: function(e) {
if (template) {
if (template && !_this.delegateAdd) {
var froms = e.from.querySelectorAll("template[is='dom-repeat']");
var from = froms[froms.length-1];
var model = from.modelForElement(e.item);
Expand All @@ -106,8 +122,10 @@
if (e.target.group.pull === 'clone') {
return false;
}
if (template) {
var item = template.splice("items", e.oldIndex, 1)[0];
if (template) {
if (!_this.delegateRemove) {
var item = template.splice("items", e.oldIndex, 1)[0];
}
e.model = {item: item};
}
_this.fire("remove", e);
Expand Down