Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use structures to describe STDP config #930

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Use structures to describe STDP config #930

merged 1 commit into from
Nov 17, 2020

Conversation

dkfellows
Copy link
Member

@dkfellows dkfellows commented Nov 16, 2020 •
edited
Loading

Part of my long-term plan to expunge plain address arithmetic; part of what I was doing in #857

@dkfellows
Use structures to describe STDP config
7496f21 
Part of my long-term plan to expunge plain address arithmetic
@dkfellows dkfellows added enhancement minor Not especially important. Might be cleanup activity, etc. labels Nov 16, 2020
andrewgait
andrewgait approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@andrewgait andrewgait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, though I didn't notice a sPyNNaker8 branch to run the integration tests for it?

@dkfellows dkfellows mentioned this pull request Nov 17, 2020
Closed
@dkfellows
Copy link
Member Author

The trigger's now cooking

rowleya
rowleya approved these changes Nov 17, 2020
View reviewed changes
Copy link
Member

@rowleya rowleya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore my silly comments. This all looks good (and master isn't broken thankfully)

@andrewgait
Copy link
Contributor

Ignore my silly comments. This all looks good (and master isn't broken thankfully)

I'd like to think I'd have noticed STDP was broken in master before now... ;)

@dkfellows dkfellows merged commit caf7e4b into master Nov 17, 2020
@dkfellows dkfellows deleted the stdp-config-structs branch November 17, 2020 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewgait andrewgait andrewgait approved these changes

@rowleya rowleya rowleya approved these changes

Assignees
No one assigned
Labels
enhancement minor Not especially important. Might be cleanup activity, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkfellows @andrewgait @rowleya