Handle LoginPayloadResponse in UpstreamBridge #3758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
also change a little check for loginpayloads it should only be possible to use this method while in login phase.
|
in my case i try to use the sendData method of the pendingConnection in the post login event for latest client version, it should work as the connection is in login state. But the LoginPayloadResponse is handled in the upstream bridge, thats why it doesnt work |
|
But the PostLoginEvent has a UserConnection not a PendingConnection? |
|
Yeah but i get the pending connection of the userconnection |
|
Why? |
|
Because i want to make use of the loginpayload api Everything should work but the packet handler for the loginpayload response is only in the initial handler, so i need to move the code down or impl it in the upstreambridge to fallback to the initialhandler Which might be better |
Outfluencer
changed the title
JonnygamingTv
added a commit
to JonnygamingTv/BungeeCord
that referenced
this pull request
Nov 19, 2024
SpigotMC#3758: Handle LoginPayloadResponse in UpstreamBridge
md-5
pushed a commit
that referenced
this pull request
Jan 22, 2025
Required for #3758 to function correctly.
LucazPlays
pushed a commit
to teamholy-network/HolyBungee
that referenced
this pull request
Jan 27, 2025
…dHandle Required for SpigotMC#3758 to function correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also change a little check for loginpayloads sendData method
it should only be possible to use this method while in login phase.
I moved the setHandler down because if in the PostLoginEvent a method is invoked that utilizeses login api. the packets will be handled in the UpstreamBridge and not in the initial handler, so the api will not function as expected