Expose ChannelInitializerHolder in protocol module #3776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think if we're going to go down this path it should be a proper factory design |
Can you tell me what a proper factory design looks like for you? |
…to make-channel-init-accessable # Conflicts: # protocol/src/main/java/net/md_5/bungee/protocol/holder/ChannelInitializerHolder.java # proxy/src/main/java/net/md_5/bungee/netty/PipelineUtils.java
md-5
reviewed
Feb 8, 2025
| * Holds the channel initializer for incoming connections | ||
| */ | ||
| @Getter | ||
| private static BungeeChannelInitializer frontendHolder; |
There was a problem hiding this comment.
Should i put the non static objects into BungeeCord.java and make them accessable via
ProxyServer.getInstance().unsafe()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the protocol module already exposes netty, i think its the best to also put this ChannelInitializerHolder here.
It allows for big plugins like Geyser and ViaVersion to access and modify the channel initializers of the serverchild and backendconnector.
This PR makes the development of software that modifies the networking much easier
I tried to impl it as simple as possible, and expose only the ChannelInitilizers in a nice way