Implement missing endpoints and small fixes #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement the service to create a new repo using a template according https://docs.github.com/en/rest/repos/repos#create-a-repository-using-a-template specs (endpoint: /repos/{template_owner}/{template_repo}/generate)
Current Github docs specify most of the parameters as optional. This commit update the existing editRepository method to these specs. https://docs.github.com/en/rest/repos/repos#update-a-repository
Update the existing method addCollaborator to meet the current docs. https://docs.github.com/en/rest/collaborators/collaborators#add-a-repository-collaborator Instead of NO_CONTENT, the expected status code is CREATED.
|
Thanks for putting up a PR. I'll take a look. |
robrbecker
reviewed
Nov 5, 2022
robrbecker
reviewed
Nov 5, 2022
Co-authored-by: Rob Becker <[email protected]>
Co-authored-by: Rob Becker <[email protected]>
|
I'm sorry about the delay. I completely forgot this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I had to update some parts of the code to use on my project.
These are the modifications included:
Would you like to include theses changes on your project?
Best regards,
Ian Maciel