Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make User field nullable in PullRequestReview #383

Merged
merged 3 commits into from
Jan 3, 2024

Conversation

mosuem
Copy link
Contributor

@mosuem mosuem commented Aug 7, 2023

As the response can contain a null user if it was deleted and now is Ghost, see

curl -L https://api.github.com/repos/dart-lang/http2/pulls/83/reviews

@CaseyHillers
Copy link
Collaborator

@mosuem this LGTM. Can you uprev the version in pubspec.yaml and add a changelog entry?

@mosuem
Copy link
Contributor Author

mosuem commented Jan 2, 2024

@CaseyHillers done!

@CaseyHillers CaseyHillers merged commit 6b9678e into SpinlockLabs:master Jan 3, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants