Skip to content

Add missing StringRepresentable #2589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 14, 2025
Merged

Add missing StringRepresentable #2589

merged 3 commits into from
Sep 14, 2025

Conversation

MrHell228
Copy link
Contributor

@MrHell228 MrHell228 commented Apr 5, 2025 •
edited
Loading

SpongeAPI | Sponge

@MrHell228 MrHell228 mentioned this pull request Apr 5, 2025
Closed
@Yeregorix
Copy link
Member

PushReaction is not a StringRepresentable in MC internals. Do we want it to be StringRepresentable in our API?
The rest LGTM.

@MrHell228
Copy link
Contributor Author

Huh, I believe I looked through internals while doing this PR. I'm not sure how this happened, will remove it

@Yeregorix Yeregorix merged commit 23dfbfd into SpongePowered:api-14 Sep 14, 2025
4 checks passed
@MrHell228 MrHell228 deleted the api-14-string-representable branch September 15, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrHell228 @Yeregorix