Skip to content

Commit

Permalink
Merge pull request #332 from setswei/FixUnitTests
Browse files Browse the repository at this point in the history
Fix e2e tests, drop Ubuntu18
  • Loading branch information
arm4b authored Oct 19, 2023
2 parents 222ee03 + 7ea9b45 commit 8532b96
Show file tree
Hide file tree
Showing 17 changed files with 7 additions and 109 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/e2e.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@ jobs:
- unstable
os:
- centos7
- ubuntu18
- rockylinux8
- ubuntu20
ansible-core:
Expand All @@ -66,6 +65,7 @@ jobs:
- name: Install Python dependencies
run: |
python3 -m pip install --upgrade pip
python3 -m pip install --upgrade "requests<=2.29.0"
python3 -m pip install --upgrade ansible-core==${{ matrix.ansible-core }}
python3 -m pip install --upgrade molecule==${{ env.MOLECULE_VERSION }}
python3 -m pip install --upgrade molecule-docker==${{ env.MOLECULE_DOCKER_VERSION }}
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@

# Log files
*.log

# Virtual Environment
.venv
6 changes: 2 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@

## Supported platforms

* Ubuntu Bionic (18.04)
* Ubuntu Focal (20.04)
* RHEL 7 and CentOS 7
* RHEL 8 and Rocky Linux 8

> If you are using the provided [`Vagrantfile`](Vagrantfile), note that it uses Bionic by default.
> If you are using the provided [`Vagrantfile`](Vagrantfile), note that it uses Focal by default.
> In order to access StackStorm Web UI, please do not forget to ensure that the http and https ports are allowed by the firewall.
Expand Down Expand Up @@ -110,7 +109,6 @@ There are a few requirements when developing on `ansible-st2`.

These are the platforms we must support (must pass end-to-end testing):

* Ubuntu Bionic (18.04)
* Ubuntu Focal (20.04)
* CentOS 7
* Rocky Linux 8
Expand All @@ -121,7 +119,7 @@ The playbooks and roles must support Ansible idempotence.
That is, re-running the `stackstorm.yml` playbook must end with the result `changed=0.*failed=0` (provided that versions and revisions are pinned).

For local development, there is a [Vagrantfile](Vagrantfile) available.
By default, the following command will set up an ubuntu18 box (`ubuntu/bionic64`):
By default, the following command will set up an ubuntu20 box (`ubuntu/focal64`):

```sh
vagrant up
Expand Down
6 changes: 1 addition & 5 deletions Vagrantfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,6 @@
# vi: set ft=ruby :

VIRTUAL_MACHINES = {
:ubuntu18 => {
:hostname => 'ansible-st2-ubuntu18',
:box => 'ubuntu/bionic64',
},
:ubuntu20 => {
:hostname => 'ansible-st2-ubuntu20',
:box => 'ubuntu/focal64',
Expand All @@ -27,7 +23,7 @@ Vagrant.configure(2) do |config|
config.ssh.forward_agent = true

VIRTUAL_MACHINES.each do |name, cfg|
config.vm.define name, autostart: (name == :ubuntu18) do |vm_config|
config.vm.define name, autostart: (name == :ubuntu20) do |vm_config|
vm_config.vm.hostname = cfg[:hostname]
vm_config.vm.box = cfg[:box]

Expand Down
1 change: 0 additions & 1 deletion meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ galaxy_info:
platforms:
- name: Ubuntu
versions:
- bionic
- focal
- name: EL
versions:
Expand Down
5 changes: 0 additions & 5 deletions molecule/ubuntu18/Dockerfile.ubuntu18.j2

This file was deleted.

83 changes: 0 additions & 83 deletions molecule/ubuntu18/molecule.yml

This file was deleted.

1 change: 0 additions & 1 deletion roles/StackStorm.mongodb/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ galaxy_info:
platforms:
- name: Ubuntu
versions:
- bionic
- focal
- name: EL
versions:
Expand Down
1 change: 0 additions & 1 deletion roles/StackStorm.nginx/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ galaxy_info:
platforms:
- name: Ubuntu
versions:
- bionic
- focal
- name: EL
versions:
Expand Down
1 change: 0 additions & 1 deletion roles/StackStorm.nodejs/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ galaxy_info:
platforms:
- name: Ubuntu
versions:
- bionic
- focal
- name: EL
versions:
Expand Down
1 change: 0 additions & 1 deletion roles/StackStorm.rabbitmq/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ galaxy_info:
platforms:
- name: Ubuntu
versions:
- bionic
- focal
- name: EL
versions:
Expand Down
1 change: 0 additions & 1 deletion roles/StackStorm.redis/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ galaxy_info:
platforms:
- name: Ubuntu
versions:
- bionic
- focal
- name: EL
versions:
Expand Down
1 change: 0 additions & 1 deletion roles/StackStorm.st2/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ galaxy_info:
platforms:
- name: Ubuntu
versions:
- bionic
- focal
- name: EL
versions:
Expand Down
1 change: 0 additions & 1 deletion roles/StackStorm.st2chatops/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ galaxy_info:
platforms:
- name: Ubuntu
versions:
- bionic
- focal
- name: EL
versions:
Expand Down
1 change: 0 additions & 1 deletion roles/StackStorm.st2repo/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ galaxy_info:
platforms:
- name: Ubuntu
versions:
- bionic
- focal
- name: EL
versions:
Expand Down
1 change: 0 additions & 1 deletion roles/StackStorm.st2smoketests/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ galaxy_info:
platforms:
- name: Ubuntu
versions:
- bionic
- focal
- name: EL
versions:
Expand Down
1 change: 0 additions & 1 deletion roles/StackStorm.st2web/meta/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ galaxy_info:
platforms:
- name: Ubuntu
versions:
- bionic
- focal
- name: EL
versions:
Expand Down

0 comments on commit 8532b96

Please sign in to comment.