Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Added TickerProvider for ViewModel , Sample usage added #1087

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: Added TickerProvider for ViewModel , Sample usage added #1087

wants to merge 1 commit into from

Conversation

okursoftware
Copy link

FilledStacks
FilledStacks requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@FilledStacks FilledStacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

Can you please explain:

  1. The problem you were trying to solve
  2. How you're solving the problem
  3. Give a concrete situation where this will be used

Thank you

example/router_example/lib/app/app.dart
@@ -39,7 +40,7 @@ import 'custom_route_transition.dart';
page: FavoritesView,
children: [
MaterialRoute(page: MultipleFuturesExampleView),
CustomRoute(page: HistoryView),
//CustomRoute(page: HistoryView),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is HistoryView removed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got an error while building, so I deleted it.

@eivihnd
Copy link
Contributor

eivihnd commented Oct 31, 2024

This seems to be the answer to one of my problems, where I need to create a TabController in the View or ViewModel.
vsync is needed, so either I need a StatefulWidget or something like this.

@okursoftware
Copy link
Author

I didn't do it to solve a problem, I wanted to do it for ease of use,
It was useful for me to use tickerprovider in viewModel class instead of making StatefullWidget unnecessarily,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilledStacks FilledStacks FilledStacks requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@okursoftware @eivihnd @FilledStacks