parse_file: performance improvements#34
Merged
grg merged 4 commits intoStanfordVLSI:masterfrom Mar 3, 2026
Merged
Conversation
steveri
reviewed
Mar 2, 2026
PerlLibs/Genesis2/Manager.pm
Outdated
| # | ||
| # Performance optimization: | ||
| # Run a "fast" regex to see if a line contains a potential perl | ||
| # expression (//; or `). Do more throrough processing only if this |
Contributor
There was a problem hiding this comment.
typo here..."throrough"...I leave it to you if you think it's worth correcting...
Collaborator
Author
There was a problem hiding this comment.
Thanks for pointing it out. I'll correct before merging.
steveri
approved these changes
Mar 2, 2026
Contributor
steveri
left a comment
steveri
left a comment
There was a problem hiding this comment.
Looks complicated....I'm mostly going to just trust you and the CI on this one...
Restructure parse_file slightly to improve performance, based on observations from a perl profile. Changes: - Perform full processing only on lines with a potential perl escape (//; or `). - Avoid duplicate regex processing. - When performing full processing of a line, invoke length only once, and eliminate duplicate substr calls. Performance improvements in parse_file runtime: - Test program 1: ~4.5s -> 1s - Test program 2: ~15s -> ~5s
Reset the prev_backslash var when processing a backtick character in parse_file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restructure parse_file slightly to improve performance, based on observations from a perl profile.
Changes:
Performance improvements in parse_file runtime: