add mechanism to disable module cache#37
Merged
grg merged 5 commits intoStanfordVLSI:masterfrom Mar 3, 2026
Merged
Conversation
Collaborator
Author
|
@steveri The module cache code was added last year. We never override parameters so it works well for us, but it could break things if parameters are overridden. It's probably better to do one of these longer term:
|
The module cache helps speed up generation by identifying when a module is generated multiple times with the same parameters and skipping duplicate generations. (This can be manually handled via clone calls. Clone is feasible within a module, but becomes difficult across modules.) One problem right now is that the duplicate detection logic only looks at the parameters begin passed to the currently module; it doesn't consider parameters lower down in the hierarchy that may be overridden via one of the override mechanisms (e.g., command line, XML, ...).
cd0d27e to
594990d
Compare
Collaborator
Author
|
I actually added a test case this time 🎉 The Genesis invocation in the test includes |
steveri
approved these changes
Mar 3, 2026
Contributor
steveri
left a comment
There was a problem hiding this comment.
Great! Thanks for the new test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The module cache helps speed up generation by identifying when a module is generated multiple times with the same parameters and skipping duplicate generations. (This can be manually handled via clone calls. Clone is feasible within a module, but becomes difficult across modules.)
One problem right now is that the duplicate detection logic only looks at the parameters begin passed to the currently module; it doesn't consider parameters lower down in the hierarchy that may be overridden via one of the override mechanisms (e.g., command line, XML, ...).