[Enhancement] Profile enhance

[before-Sunrise]

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

• BugFix
• Feature
• Enhancement
• Refactor
• UT
• Doc
• Tool

Does this PR entail a change in behavior?

• Yes, this PR will result in a change in behavior.
• No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

• Interface/UI changes: syntax, type conversion, expression evaluation, display information
• Parameter changes: default values, similar parameters but with different default values
• Policy changes: use new policy to replace old one, functionality automatically enabled
• Feature removed
• Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

• I have added test cases for my bug fix or my new feature
• This pr needs user documentation (for new or modified features or behaviors)
• I have added documentation for my new feature or new function
• This is a backport pr

Bugfix cherry-pick branch check:

• I have checked the version labels which the pr will be auto-backported to the target branch
  • 3.3
  • 3.2
  • 3.1
  • 3.0
  • 2.5

[starrocks-cr]

The most risky bug in this code is:
If TOTAL_QUERIES.pollFirst() returns null because the deque is empty or has concurrent modifications, a NullPointerException might occur when calling head.getQueryId().

You can modify the code like this:

private static void removeExpiredQueryDetails() {
    long deleteTime = getCurrentTimeNS() - Config.query_detail_cache_time_nanosecond;

    while (!TOTAL_QUERIES.isEmpty()) {
        QueryDetail head = TOTAL_QUERIES.peekFirst();
        if (head != null && head.getEventTime() < deleteTime) {
            TOTAL_QUERIES.pollFirst(); 
            QUERY_MAP.remove(head.getQueryId());
        } else {
            break;
        }
    }
}

[starrocks-cr]

The most risky bug in this code is:
Not handling potential NullPointerException when accessing profileRequest.profileIds.
You can modify the code like this:

public void execute(BaseRequest request, BaseResponse response) throws DdlException {
    String jsonStr = request.getContent();

    Gson gson = new Gson();
    ProfileRequest profileRequest;

    try {
        Type type = new TypeToken<ProfileRequest>() {}.getType();
        profileRequest = gson.fromJson(jsonStr, type);

        // Add a null check for profileRequest to avoid NPE
        if (profileRequest == null || profileRequest.profileIds == null || profileRequest.profileIds.isEmpty()) {
            response.getContent().append("profileIds cannot be empty");
            sendResult(request, response, HttpResponseStatus.BAD_REQUEST);
            return;
        }
    } catch (Exception e) {
        response.getContent().append("not valid parameter");
        sendResult(request, response, HttpResponseStatus.BAD_REQUEST);
        return;
    }

    List<String> profileIds = profileRequest.profileIds;
    List<String> profiles = QueryDetailQueue.getQueryProfilesByQueryIds(profileIds);

    String jsonString = gson.toJson(profiles);
    response.getContent().append(jsonString);
    sendResult(request, response);
}

This fix ensures that if gson.fromJson returns null, the method will handle it properly by attaching an error message and returning an appropriate HTTP response.

[sonarcloud]

Quality Gate passed

Issues
5 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

[github-actions]

[FE Incremental Coverage Report]

✅ pass : 46 / 46 (100.00%)

file detail

	path	covered_line	new_line	coverage	not_covered_line_detail
🔵	com/starrocks/qe/QueryDetail.java	6	6	100.00%	[]
🔵	com/starrocks/qe/QueryDetailQueue.java	13	13	100.00%	[]
🔵	com/starrocks/qe/StmtExecutor.java	2	2	100.00%	[]
🔵	com/starrocks/http/rest/QueryDetailProfileAction.java	24	24	100.00%	[]
🔵	com/starrocks/http/HttpServer.java	1	1	100.00%	[]