Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Optimize ProcProfile logging time #52829

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

gengjun-git
Copy link
Contributor

Why I'm doing:

Due to some permission reasons, the Profile may not be executed. To avoid repeated log printing, set a log printing interval.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@gengjun-git
Copy link
Contributor Author

@Mergifyio rebase

Signed-off-by: gengjun-git <[email protected]>
Copy link
Contributor

mergify bot commented Nov 12, 2024

rebase

✅ Branch has been successfully rebased

Copy link

sonarcloud bot commented Nov 12, 2024

Copy link

[Java-Extensions Incremental Coverage Report]

pass : 0 / 0 (0%)

Copy link

[FE Incremental Coverage Report]

fail : 11 / 14 (78.57%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/memory/ProcProfileCollector.java 11 14 78.57% [153, 154, 155]

Copy link

[BE Incremental Coverage Report]

pass : 0 / 0 (0%)

@gengjun-git gengjun-git enabled auto-merge (squash) November 13, 2024 02:09
@andyziye andyziye merged commit 1d43043 into StarRocks:main Nov 13, 2024
43 of 44 checks passed
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Nov 13, 2024
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label Nov 13, 2024
Copy link
Contributor

mergify bot commented Nov 13, 2024

backport branch-3.3

✅ Backports have been created

Copy link
Contributor

mergify bot commented Nov 13, 2024

backport branch-3.2

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 13, 2024
Signed-off-by: gengjun-git <[email protected]>
(cherry picked from commit 1d43043)
mergify bot pushed a commit that referenced this pull request Nov 13, 2024
Signed-off-by: gengjun-git <[email protected]>
(cherry picked from commit 1d43043)
wanpengfei-git pushed a commit that referenced this pull request Nov 13, 2024
wanpengfei-git pushed a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants