Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] fix in-memory pk index memory leak (backport #52903) #52904

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 14, 2024

Why I'm doing:

In shared-data cluster, when we create a PK table with enable_persistent_index=false, then we will use in-memory index. But it has memory leak issue now because _calc_memory_usage won't be called because PrimaryIndex::load and PrimaryIndex::commit won't be called in LakePrimaryIndex.

What I'm doing:

This pull request includes updates to the PrimaryIndex class in be/src/storage/primary_index.cpp to improve memory usage tracking. The changes ensure that memory usage is recalculated after each operation involving the primary key to row ID mapping.

Memory usage tracking improvements:

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

This is an automatic backport of pull request #52903 done by [Mergify](https://mergify.com). ## Why I'm doing: In shared-data cluster, when we create a PK table with `enable_persistent_index=false`, then we will use in-memory index. But it has memory leak issue now because `_calc_memory_usage` won't be called because `PrimaryIndex::load` and `PrimaryIndex::commit` won't be called in `LakePrimaryIndex`.

What I'm doing:

This pull request includes updates to the PrimaryIndex class in be/src/storage/primary_index.cpp to improve memory usage tracking. The changes ensure that memory usage is recalculated after each operation involving the primary key to row ID mapping.

Memory usage tracking improvements:

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Signed-off-by: luohaha <[email protected]>
(cherry picked from commit 20e446e)
@wanpengfei-git wanpengfei-git merged commit 0f538e7 into branch-3.3 Nov 14, 2024
32 of 33 checks passed
@wanpengfei-git wanpengfei-git deleted the mergify/bp/branch-3.3/pr-52903 branch November 14, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants