Skip to content

style: lint the train test files now that train/ is in scope - #214

Merged
ASuresh0524 merged 1 commit into
mainfrom
fix/train-tests-lint
Nov 17, 2026
Merged

ASuresh0524 merged 1 commit into
mainfrom
fix/train-tests-lint

Conversation

@ASuresh0524

Copy link
Copy Markdown
Collaborator

main is currently failing Python lint. #209 removed train from the ruff exclude list; #205 and #206 added train/tests/test_loss_world_size.py and train/tests/test_loss_fn_wiring.py while it was still excluded, so those files had never been linted.

Each PR was green on its own branch — the combination is what nobody ran, including me when I merged them.

train/tests/test_loss_world_size.py:26:33: RUF100 Unused `noqa` directive (non-enabled: `E402`)
2 files would be reformatted, 203 files already formatted

Fixed with ruff check --fix and ruff format scoped to train/tests/. After it:

  • ruff check . — all checks passed
  • ruff format --check . — 205 files already formatted
  • uv run pytest tests/ — 362 passed, 3 skipped

🤖 Generated with Claude Code

#209 removed `train` from the ruff exclude list, and #205/#206 added these
two test files while it was still excluded, so they had never been checked.
Together on main they fail CI:

    train/tests/test_loss_world_size.py:26:33: RUF100 Unused `noqa` directive
    2 files would be reformatted

Each PR was green on its own; the combination was what nobody ran. Fixed with
`ruff check --fix` and `ruff format` over train/tests/ only.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Nov 17, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
web Ready Ready Preview Nov 17, 2026 8:25am UTC

@ASuresh0524
ASuresh0524 merged commit 94fdad2 into main Nov 17, 2026
7 checks passed
@ASuresh0524
ASuresh0524 deleted the fix/train-tests-lint branch November 17, 2026 08:29

This branch was successfully deployed

1 active deployment
Preview — 5446a2fa Deployed Nov 17, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant