[pull] master from JetBrains:master

[pull]

See Commits and Changes for more details.

---

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

This pull request introduces new features and enhancements related to pull/merge request creation notifications, auto-test toolbar, and JPMS module access checks. It also includes performance improvements and bug fixes for the debugger.

New Features:

• Adds actions to push notifications to open existing pull/merge requests or create new ones for GitHub and GitLab.
• Adds a floating toolbar to the editor for auto-test status in Java projects.

Bug Fixes:

• Fixes a bug where the debugger could deadlock when awaiting a CompletableFuture on the Debugger Manager Thread (DMT).

Enhancements:

• Refactors JPMS module access checks in JavaPlatformModuleSystem to improve code clarity and correctness.
• Improves the performance of the debugger by caching helper classes and using asynchronous operations.
• Improves the performance of the debugger by avoiding deadlocks when awaiting CompletableFuture on DMT.

CI:

• Adds MAVEN_IN_DOCKER_INTEGRATION_TESTS test group.

[gitstream-cm]

🚨 gitStream Monthly Automation Limit Reached 🚨

Your organization has exceeded the number of pull requests allowed for automation with gitStream.
Monthly PRs automated: 1940/250

To continue automating your PR workflows and unlock additional features, please contact LinearB.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request includes several bug fixes and improvements across different areas of the IDE, including JPMS module access checks, GitHub and GitLab integration, debugger UI, auto-test toolbar, Python version checks, plugins UI, floating toolbar, main toolbar, command completion, and debugger.

Sequence diagram for GitHub push notification with existing PR

sequenceDiagram
    participant GitPlugin as GP
    participant GHPushNotificationCustomizer as GHNC
    participant GHRepositoryConnectionManager as GHCM
    participant GHAccountManager as GHA
    participant GithubApiRequestExecutor as GAE
    participant PullRequests as PR
    GP->GHNC: getActions(repository, pushResult, customParams)
    GHNC->GHCM: getConnectionState()
    alt connection == null
        GHNC->GHNC: findRepositoryAndAccount()
        GHNC->GHA: accountsState()
    end
    GHNC->GHNC: canCreateReview(projectMapping, account, remoteBranch)
    GHNC->GHA: findCredentials(account)
    GHA-->>GHNC: token
    GHNC->GAE: create(server, token)
    GHNC->GAE: executeSuspend(Repo.find(repository))
    alt defaultBranch == remoteBranchName
        GHNC-->>GP: []
    else
        GHNC->GHNC: findExistingPullRequests(projectMapping, account, remoteBranch)
        GHNC->GAE: executeSuspend(PullRequests.find(repository, state, baseRef, headRef))
        PR-->>GAE: items
        alt items.size == 0
            GHNC-->>GP: [GHPRCreatePullRequestNotificationAction]
        else items.size == 1
            GHNC-->>GP: [GHOpenPullRequestExistingTabNotificationAction]
        else items.size > 1
            GHNC-->>GP: []
        end
    end

Loading

Sequence diagram for GitLab push notification with existing MR

sequenceDiagram
    participant GitPlugin as GP
    participant GitLabPushNotificationCustomizer as GLNC
    participant GitLabProjectConnectionManager as GLCM
    participant GitLabAccountManager as GLA
    participant GitLabApiManager as GLAM
    participant GitLabApi as GLApi
    participant GraphQL as GQL
    GP->GLNC: getActions(repository, pushResult, customParams)
    GLNC->GLCM: getConnectionState()
    alt connection == null
        GLNC->GLNC: findRepositoryAndAccount()
        GLNC->GLA: accountsState()
    end
    GLNC->GLNC: canCreateReview(projectMapping, account, remoteBranch)
    GLNC->GLA: findCredentials(account)
    GLA-->>GLNC: token
    GLNC->GLAM: getClient(server, token)
    GLAM-->>GLNC: api
    GLNC->GLApi: getRepositoryInfo(api, repository)
    GLApi->GQL: find(repository)
    alt rootRef == remoteBranchName
        GLNC-->>GP: []
    else
        GLNC->GLNC: findExistingMergeRequests(projectMapping, account, remoteBranch)
        GLNC->GLA: findCredentials(account)
        GLA-->>GLNC: token
        GLNC->GLAM: getClient(server, token)
        GLAM-->>GLNC: api
        GLNC->GQL: findMergeRequestsByBranch(project, state, remoteBranchName)
        GQL-->>GLNC: nodes
        alt nodes.size == 0
            GLNC-->>GP: [GitLabMergeRequestOpenCreateTabNotificationAction]
        else nodes.size == 1
            GLNC-->>GP: [GitLabOpenMergeRequestExistingTabNotificationAction]
        else nodes.size > 1
            GLNC-->>GP: []
        end
    end

Loading

Updated class diagram for JavaPlatformModuleSystem

classDiagram
    class JavaPlatformModuleSystem {
        -ERR
        +getName()
        +isAccessible(targetPackageName, targetFile, place)
        +checkAccess(targetPackageName, targetFile, place)
        +isAccessible(targetModule, place)
        +checkAccess(targetModule, place)
        -getProblem(targetPackageName, targetFile, place, quick, isAccessible)
        -checkAccess(target, place, quick, isAccessible)
        +toErrorWithFixes(problem, place)
        -getMessage(problem)
        -getFixes(problem, place)
    }

    class JpmsModuleAccessInfo {
        +toErrorWithFixes(problem, place)
        -getMessage(problem)
        -getFixes(problem, place)
    }

    JavaPlatformModuleSystem -- JpmsModuleAccessInfo : uses

Loading

File-Level Changes

Change	Details	Files
Refactor JPMS module access checks for improved clarity and correctness.	Introduce JpmsModuleAccessInfo to encapsulate access details between modules. Introduce JpmsModuleInfo to represent JPMS module information. Refactor checkAccess methods to use JpmsModuleAccessInfo and JpmsModuleInfo. Introduce JpmsModuleAccessProblem enum to represent different access problems. Move JPMS related methods from JavaPsiModuleUtil to JpmsModuleAccessInfo. Remove ModuleAccessInfo and ModuleInfo. Remove JavaModuleGraphUtil.exports method and use JavaPsiModuleUtil.exports instead.	java/java-impl/src/com/intellij/psi/impl/JavaPlatformModuleSystem.kt java/codeserver/core/src/com/intellij/java/codeserver/core/JavaPsiModuleUtil.java java/codeserver/core/src/com/intellij/java/codeserver/core/JpmsModuleAccessInfo.kt java/codeserver/core/src/com/intellij/java/codeserver/core/JpmsModuleInfo.kt java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/analysis/JavaModuleGraphUtil.java java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/AddExportsOptionFix.kt java/java-analysis-impl/src/com/intellij/codeInsight/daemon/impl/quickfix/AddModulesOptionFix.kt
Enhance GitHub and GitLab push notification customizers to handle existing pull/merge requests.	Add logic to find existing open pull/merge requests for the pushed branch. Modify notification actions to open existing pull/merge requests if found, or create a new one if none exist. Add new notification actions GHOpenPullRequestExistingTabNotificationAction and GitLabOpenMergeRequestExistingTabNotificationAction. Refactor canCreateReview methods to only check if creating a PR/MR is valid, not if one already exists.	plugins/github/github-core/src/org/jetbrains/plugins/github/notification/GHPushNotificationCustomizer.kt plugins/github/github-core/src/org/jetbrains/plugins/github/pullrequest/action/GHPRCreatePullRequestAction.kt plugins/gitlab/gitlab-core/src/org/jetbrains/plugins/gitlab/notification/GitLabPushNotificationCustomizer.kt plugins/gitlab/gitlab-core/src/org/jetbrains/plugins/gitlab/mergerequest/ui/create/action/GitLabMergeRequestOpenCreateTabAction.kt
Implement a proxy for XDebugSession to support split UI mode.	Introduce XDebugSessionProxy interface and XDebugSessionProxyKeeper service. Modify XDebugSessionTab and related classes to use XDebugSessionProxy instead of XDebugSession directly. Implement Monolith class that implements XDebugSessionProxy and wraps XDebugSession. Update XDebugView to use XDebugSessionProxy. Add logic to handle split UI mode in XDebugSessionTab3 and XDebugSessionTabNewUI.	platform/xdebugger-impl/src/com/intellij/xdebugger/impl/ui/XDebugSessionTab.java platform/xdebugger-impl/src/com/intellij/xdebugger/impl/ui/XDebugSessionTab3.kt platform/xdebugger-impl/src/com/intellij/xdebugger/impl/ui/XDebugSessionTabNewUI.kt platform/xdebugger-impl/src/com/intellij/xdebugger/impl/frame/XDebugView.java platform/xdebugger-impl/src/com/intellij/xdebugger/impl/frame/XDebugSessionProxy.kt platform/xdebugger-impl/src/com/intellij/xdebugger/impl/frame/XDebugSessionProxyKeeper.kt platform/xdebugger-impl/src/com/intellij/xdebugger/impl/frame/XDebugViewSessionListener.java
Refactor auto-test floating toolbar to use console properties and execution listeners.	Remove JavaAutoRunFloatingToolbarService and JavaAutoRunFloatingToolbarState. Use TestConsoleProperties.SHOW_AUTO_TEST_TOOLBAR to control toolbar visibility. Add an execution listener to update the current configuration and toolbar visibility after each run. Update the toolbar visibility when auto-test is enabled or disabled. Update the toolbar visibility when the SHOW_AUTO_TEST_TOOLBAR property changes.	java/execution/impl/src/com/intellij/execution/testDiscovery/JavaAutoRunFloatingToolbarProvider.kt
Add support for version and platform checks in Python code.	Implement PyVersionCheck object to convert expressions to version ranges. Modify evaluateVersionsForElement function to use PyVersionCheck. Update PyVersionAwareElementVisitor to use PyVersionCheck. Add convertToVersionRanges method to PyVersionCheck to convert PyIfPart to version ranges.	python/python-psi-api/src/com/jetbrains/python/psi/impl/PyVersionCheck.kt python/python-psi-impl/src/com/jetbrains/python/psi/impl/stubs/PyVersionSpecificStubBase.kt python/python-psi-api/src/com/jetbrains/python/psi/impl/PyVersionAwareElementVisitor.kt
Fixes and improvements to the plugins UI.	Add a padlock icon to the plugin name component when the plugin is not free in free mode. Add a banner to the plugin details page when the plugin is not free in free mode. Add a tooltip to the plugin list item when the plugin is not free in free mode. Fix a bug where the error component was not updated correctly when the plugin was disabled. Fix a bug where the align button was not visible when the restart button was visible.	platform/platform-impl/src/com/intellij/ide/plugins/newui/ListPluginComponent.java platform/platform-impl/src/com/intellij/ide/plugins/newui/PluginDetailsPageComponent.kt platform/platform-api/resources/messages/IdeBundle.properties java/idea-ui/resources/messages/JavaUiBundle.properties
Fixes and improvements to the floating toolbar.	Add onHiddenByEsc method to FloatingToolbarProvider to notify when the toolbar is hidden by the Esc key. Call onHiddenByEsc when the toolbar is hidden by the Esc key. Notify the hot swap manager when the toolbar is hidden by the Esc key or by the user. Add debug logging to the hot swap manager.	platform/platform-impl/src/com/intellij/openapi/editor/toolbar/floating/FloatingToolbarProvider.kt platform/platform-impl/src/com/intellij/openapi/editor/toolbar/floating/EditorFloatingToolbar.kt platform/debugger-impl/frontend/src/com/intellij/platform/debugger/impl/frontend/hotswap/HotSwapFloatingToolbarProvider.kt
Fixes and improvements to the main toolbar.	Update actions asynchronously when the UI is updated. Fix a bug where the main menu button was not updated correctly when the window was resized.	platform/platform-impl/src/com/intellij/openapi/wm/impl/headertoolbar/MainToolbar.kt platform/platform-impl/src/com/intellij/openapi/actionSystem/impl/ActionToolbarImpl.java
Fixes and improvements to the command completion.	Add statistics collection for command completion. Fix a bug where the command text after the dots was not removed correctly.	platform/lang-impl/src/com/intellij/codeInsight/completion/command/CommandInsertHandler.kt platform/lang-impl/src/com/intellij/codeInsight/completion/command/CommandCompletionProvider.kt platform/lang-impl/src/com/intellij/codeInsight/completion/command/CommandCompletionCollector.kt
Fixes and improvements to the debugger.	Fix a bug where the source position was not computed correctly for Java values. Fix a bug where the helper class cache was not cleared correctly. Fix a bug where the debugger was not working correctly with Dex.	java/debugger/impl/src/com/intellij/debugger/engine/JavaValueUtils.kt java/debugger/impl/src/com/intellij/debugger/impl/DebuggerUtilsAsync.java java/debugger/impl/src/com/intellij/debugger/engine/JavaValue.java java/debugger/impl/src/com/intellij/debugger/impl/HelperClassCache.kt java/debugger/impl/src/com/intellij/debugger/impl/JdiHelperClassLoaderImpl.kt java/debugger/impl/src/com/intellij/debugger/impl/asyncCommands.kt java/debugger/impl/src/com/intellij/debugger/impl/DexDebugFacility.kt plugins/kotlin/jvm-debugger/base/util/src/org/jetbrains/kotlin/idea/debugger/base/util/DexDebugFacility.kt plugins/kotlin/jvm-debugger/core/src/org/jetbrains/kotlin/idea/debugger/core/filter/KotlinSyntheticTypeComponentProvider.kt plugins/kotlin/jvm-debugger/core/src/org/jetbrains/kotlin/idea/debugger/core/stackFrameUtils.kt plugins/kotlin/jvm-debugger/core/src/org/jetbrains/kotlin/idea/debugger/stepping/smartStepInto/KotlinLambdaAsyncMethodFilter.kt plugins/kotlin/jvm-debugger/core/src/org/jetbrains/kotlin/idea/debugger/stepping/smartStepInto/KotlinSmartStepIntoHandler.kt plugins/kotlin/jvm-debugger/evaluation/src/org/jetbrains/kotlin/idea/debugger/evaluate/classLoading/AndroidOClassLoadingAdapter.kt plugins/kotlin/jvm-debugger/evaluation/src/org/jetbrains/kotlin/idea/debugger/evaluate/classLoading/OrdinaryClassLoadingAdapter.kt

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.