Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from JetBrains:master #213

Merged
merged 6 commits into from
Feb 25, 2025
Merged

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 25, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

This pull request refactors the document binding and synchronization logic in the AD (Abstract Document) system. It introduces a new DocumentEntityManager service for managing document entities and a DocumentEntityProvider extension point for customizing entity creation and deletion. The changes aim to improve the flexibility and maintainability of the AD system.

Enhancements:

  • Refactor the document binding and synchronization logic to use a new DocumentEntityManager service for managing document entities.
  • Introduce a DocumentEntityProvider extension point to allow different strategies for creating and deleting document entities.
  • Implement a default DocumentEntityProvider that creates entities based on the file ID.
  • Add a MyFileDocumentBindingListener to listen for file-document binding changes and trigger entity binding.
  • Introduce an EntityCleanService to register entities for cleanup when they become unreachable.
  • Remove the DocumentEntityHandle data class and related logic.
  • Remove the BindType enum.
  • Remove the docToHandle map.

trushev and others added 6 commits February 25, 2025 02:34
GitOrigin-RevId: e652adb4b0daf0068c1e6a78b6cc7edcde03063f
#KTIJ-25195

GitOrigin-RevId: 0ae2500948914bc44946e2a1c55b7a39c5f7032a
#KTIJ-33210

GitOrigin-RevId: aadcd8b1143ec0b1fbc822411058d5d5589f4cbd
…progress

GitOrigin-RevId: 964b5e01907f60a83a0e0b303ce1e0e63c4d2d41
GitOrigin-RevId: 9931c6ea00a29846466c86a12e106dcbf6b7fe55
GitOrigin-RevId: 0f77aee04ab41b053887f490c10079bbbef2d662
@pull pull bot added the ⤵️ pull label Feb 25, 2025
@pull pull bot merged commit 263c161 into Stars1233:master Feb 25, 2025
Copy link

gitstream-cm bot commented Feb 25, 2025

🚨 gitStream Monthly Automation Limit Reached 🚨

Your organization has exceeded the number of pull requests allowed for automation with gitStream.
Monthly PRs automated: 2207/250

To continue automating your PR workflows and unlock additional features, please contact LinearB.

Copy link

sourcery-ai bot commented Feb 25, 2025

Reviewer's Guide by Sourcery

This pull request updates various Kotlin compiler plugin dependencies to a newer version and refactors the AdTheManager class to improve document entity management.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Update Kotlin compiler plugin dependencies to a newer version.
  • Updated the version of Kotlin compiler plugin dependencies from 2.2.0-dev-6100 to 2.2.0-dev-6736.
  • Modified the URLs, SHA256 checksums, and downloaded file paths to reflect the new version.
lib/MODULE.bazel
lib/BUILD.bazel
Refactor AdTheManager class to improve document entity management.
  • Removed methods related to document entity binding and replaced them with a new DocumentEntityManager service.
  • Introduced a new DocumentEntityManager class to handle document entity creation and deletion.
  • Added a new AdDocumentSynchronizer class to synchronize document changes with the backend.
  • Updated the AdTheManager class to use the new DocumentEntityManager for document entity management.
platform/platform-impl/src/com/intellij/openapi/editor/impl/ad/AdTheManager.kt
platform/platform-impl/src/com/intellij/openapi/editor/impl/ad/document/DocumentEntityManager.kt
platform/platform-impl/src/com/intellij/openapi/editor/impl/ad/document/AdDocumentSynchronizer.kt
Add support for test resources in Bazel build files.
  • Added jvm_resources targets for test resources in various BUILD.bazel files.
  • Updated runtime_deps to include test resources where applicable.
python/BUILD.bazel
platform/testFramework/BUILD.bazel
platform/util/BUILD.bazel
plugins/lombok/BUILD.bazel
plugins/ui-designer/BUILD.bazel
jps/model-serialization/BUILD.bazel
plugins/devkit/devkit-java-tests/BUILD.bazel
plugins/devkit/devkit-kotlin-tests/BUILD.bazel
plugins/gradle/BUILD.bazel
xml/tests/BUILD.bazel
jps/jps-builders/BUILD.bazel
jps/model-impl/BUILD.bazel
json/tests/BUILD.bazel
platform/build-scripts/codeOptimizer/BUILD.bazel
platform/build-scripts/tests/BUILD.bazel
platform/built-in-server/BUILD.bazel
platform/configuration-store-impl/BUILD.bazel
platform/diagnostic/freezeAnalyzer/BUILD.bazel
platform/diff-impl/tests/BUILD.bazel
platform/external-system-api/dependency-updater/BUILD.bazel
platform/external-system-impl/BUILD.bazel
platform/jewel/ui/BUILD.bazel
platform/ml-impl/BUILD.bazel
platform/testFramework/junit5/BUILD.bazel
platform/webSymbols/BUILD.bazel
platform/workspace/jps/tests/BUILD.bazel
platform/workspace/storage/tests/BUILD.bazel
plugins/devkit/intellij.devkit.i18n/BUILD.bazel
plugins/filePrediction/BUILD.bazel
plugins/gitlab/gitlab-core/BUILD.bazel
plugins/gradle/java/BUILD.bazel
plugins/gradle/tooling-extension-impl/BUILD.bazel
plugins/grazie/src/test/BUILD.bazel
plugins/kotlin/gradle/gradle/tests/BUILD.bazel
plugins/kotlin/project-wizard/compose/BUILD.bazel
plugins/markdown/test/BUILD.bazel
plugins/maven/src/test/BUILD.bazel
plugins/repository-search/BUILD.bazel
plugins/terminal/BUILD.bazel
plugins/toml/tests/BUILD.bazel
plugins/xpath/BUILD.bazel
plugins/yaml/backend/BUILD.bazel
python/services/system-python/BUILD.bazel
tools/intellij.tools.ide.metrics.benchmark/BUILD.bazel
tools/intellij.tools.ide.metrics.collector/BUILD.bazel
java/java-tests/BUILD.bazel
platform/jewel/ui-tests/BUILD.bazel
platform/platform-tests/BUILD.bazel
Add new extension points and listeners for document entity management.
  • Added a new extension point for documentEntityProvider in PlatformExtensionPoints.xml.
  • Registered a new listener for FileDocumentBindingListener in PlatformExtensions.xml.
platform/platform-resources/src/META-INF/PlatformExtensionPoints.xml
platform/platform-resources/src/META-INF/PlatformExtensions.xml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

coderabbitai bot commented Feb 25, 2025

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants