[pull] main from facebook:main #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…ection.getNodes() (#7135)
|
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
Reviewer's Guide by SourceryThis pull request introduces enhancements and refactoring to the LexicalCaret and LexicalNode modules, focusing on improving caret handling and node comparison functionalities. It includes new utility functions for caret comparison and common ancestor determination, as well as updates to existing methods to utilize these new utilities. Updated class diagram for LexicalCaret and LexicalNodeclassDiagram
class CaretRangeImpl {
+getTextSlices() TextPointCaretSliceTuple
+iterNodeCarets(rootMode: RootMode) IterableIterator
}
class LexicalNode {
+getCommonAncestor(node: LexicalNode) T | null
+isBefore(targetNode: LexicalNode) boolean
+isParentOf(targetNode: LexicalNode) boolean
}
class CommonAncestorResult {
<<interface>>
}
class CommonAncestorResultSame {
<<interface>>
+type: 'same'
+commonAncestor: A
}
class CommonAncestorResultAncestor {
<<interface>>
+type: 'ancestor'
+commonAncestor: A
}
class CommonAncestorResultDescendant {
<<interface>>
+type: 'descendant'
+commonAncestor: B
}
class CommonAncestorResultBranch {
<<interface>>
+type: 'branch'
+commonAncestor: ElementNode
+a: A | ElementNode
+b: B | ElementNode
}
CaretRangeImpl --> LexicalNode
CommonAncestorResult <|-- CommonAncestorResultSame
CommonAncestorResult <|-- CommonAncestorResultAncestor
CommonAncestorResult <|-- CommonAncestorResultDescendant
CommonAncestorResult <|-- CommonAncestorResultBranch
LexicalNode --> CommonAncestorResult
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Refactor and enhance caret and code highlighting functionalities by introducing new functions with
$prefixes, deprecating older methods, and adding comprehensive test cases for new features. Improve theRangeSelectionmethod for node retrieval and update documentation with deprecation notices.New Features:
$comparePointCaretNextto provide a total ordering forPointCaret<'next'>based on the order aCaretRangewould iterate them.Enhancements:
getNodesmethod inRangeSelectionto use a new function$getNodesFromCaretRangeCompatfor improved compliance with quirks of the original method.getCommonAncestormethod inLexicalNodein favor of the new$getCommonAncestorfunction for finding common ancestors of nodes.$prefix, such as$getFirstCodeNodeOfLineand$getLastCodeNodeOfLine.Documentation:
LexicalNodeand code highlighting functions, guiding users to use the new$prefixed functions.Tests:
$comparePointCaretNextand$getCommonAncestorfunctions to ensure correct functionality and ordering of caret points.