[pull] main from facebook:main

[pull]

See Commits and Changes for more details.

---

Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

Summary by Sourcery

This pull request improves table cell selection and enhances the accessibility of the typeahead menu. It ensures consistent cell selection behavior across browsers when triple-clicking and sets the appropriate ARIA attributes for the typeahead menu.

Bug Fixes:

• Fixes an issue where triple-clicking a cell in a table would select the entire document in some browsers. Now, triple-clicking a cell consistently selects the content of that cell.

Enhancements:

• Improves accessibility of the typeahead menu by setting the correct aria-label and role attributes on the container element.

Tests:

• Adds a test to verify that the typeahead menu container has the correct aria-label and role attributes.

[gitstream-cm]

🚨 gitStream Monthly Automation Limit Reached 🚨

Your organization has exceeded the number of pull requests allowed for automation with gitStream.
Monthly PRs automated: 2176/250

To continue automating your PR workflows and unlock additional features, please contact LinearB.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request focuses on improving table cell selection behavior and standardizing the attribute setting for the typeahead menu. It introduces a new command for handling table clicks and ensures consistent behavior across browsers when selecting table cells on triple click. Additionally, it encapsulates the logic for setting attributes on the typeahead menu container, ensuring consistency and removing the 'id' attribute when the menu is unmounted.

Sequence diagram for table cell selection on triple click

sequenceDiagram
  participant User
  participant TableElement
  participant Editor

  User->>TableElement: Triple click on a cell
  TableElement->>Editor: CLICK_COMMAND event
  Editor->>Editor: $tableClickCommand(event)
  Editor->>Editor: $getNearestNodeFromDOMNode(event.target)
  Editor->>Editor: $findMatchingParent(startNode)
  Editor->>Editor: blockNode.select(0)
  Editor-->>TableElement: Updates selection

Loading

Sequence diagram for LexicalMenu mounting and unmounting

sequenceDiagram
  participant ParentComponent
  participant LexicalMenu
  participant ContainerDiv

  ParentComponent->>LexicalMenu: Mounts
  LexicalMenu->>ContainerDiv: Creates or reuses ContainerDiv
  LexicalMenu->>ContainerDiv: setContainerDivAttributes(ContainerDiv, className)
  LexicalMenu->>ParentComponent: Appends ContainerDiv to parent

  ParentComponent->>LexicalMenu: Unmounts
  LexicalMenu->>ContainerDiv: Removes ContainerDiv from parent
  LexicalMenu->>ContainerDiv: removeAttribute('id')

Loading

File-Level Changes

Change	Details	Files
Standardizes table cell selection on triple click across browsers and introduces a command for handling table clicks.	Removes browser-specific handling for table cell selection on triple click in the selection test. Introduces a $tableClickCommand to handle click events on tables, selecting the content of the clicked cell. Registers the CLICK_COMMAND with the editor to trigger the $tableClickCommand. Adds a mousedown event listener to the table element to prevent default behavior on triple click within a cell. Updates applyTableHandlers to include a handler for triple click events, preventing default behavior. The CLICK_COMMAND is dispatched when a table cell is triple-clicked, ensuring the cell's content is selected.	packages/lexical-playground/__tests__/e2e/Selection.spec.mjs packages/lexical-table/src/LexicalTablePluginHelpers.ts packages/lexical-table/src/LexicalTableSelectionHelpers.ts
Ensures consistent attribute setting for the typeahead menu container in LexicalMenu.	Introduces a setContainerDivAttributes function to encapsulate the logic for setting attributes on the typeahead menu container. Uses setContainerDivAttributes to set attributes on the container div when the menu is appended to the parent. Removes the 'id' attribute from the container div when the menu is unmounted. Adds a test case to verify that the correct attributes are set on the typeahead menu container.	packages/lexical-react/src/shared/LexicalMenu.ts packages/lexical-playground/__tests__/e2e/Mentions.spec.mjs

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!
• Generate a plan of action for an issue: Comment @sourcery-ai plan on
  an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[coderabbitai]

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.