[pull] main from openfga:main #8
Merged
+893
−317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Co-authored-by: Yissell Garma <[email protected]>
Reviewer's Guide by SourceryThis pull request introduces a new version of the recursive TTU fast path algorithm ( Sequence diagram for recursiveTTUFastPathV2sequenceDiagram
participant LC as LocalChecker
participant TS as TypeSystem
participant OP as recursiveTTUObjectProvider
participant RF as recursiveFastPath
LC->TS: RecursiveTTUCanFastPathV2(objectType, relation, userType, rewrite)
TS-->LC: true
LC->OP: newRecursiveTTUObjectProvider(typesys, rewrite)
LC->RF: recursiveFastPath(ctx, req, rightIter, mapping, objectProvider)
RF->OP: Begin(ctx, req)
OP-->RF: chan usersetMessage
RF->OP: End()
Sequence diagram for constructLeftChannelssequenceDiagram
participant LC as LocalChecker
participant constructLeftChannels
participant TS as TypeSystem
participant FP as fastPathRewrite
LC->constructLeftChannels: constructLeftChannels(ctx, req, possibleParents, relationFunc)
loop for each parentType in possibleParents
constructLeftChannels->TS: GetRelation(parentType.GetType(), relationFunc(parentType))
TS-->constructLeftChannels: rel, err
constructLeftChannels->FP: fastPathRewrite(ctx, r, rel.GetRewrite())
FP-->constructLeftChannels: leftChan, err
end
constructLeftChannels-->LC: leftChans, err
Sequence diagram for fanInIteratorChannelssequenceDiagram
participant LC as LocalChecker
participant fanInIteratorChannels
LC->fanInIteratorChannels: fanInIteratorChannels(ctx, chans)
alt limit == 0
fanInIteratorChannels->LC: close(out)
else limit > 0
loop for each c in chans
fanInIteratorChannels->fanInIteratorChannels: pool.Go(func(ctx context.Context) error)
end
end
fanInIteratorChannels-->LC: out
Updated class diagram for object providersclassDiagram
class objectProvider {
End()
Begin(ctx Context, req ResolveCheckRequest) chan usersetMessage
}
class recursiveObjectProvider {
mapper storage.TupleMapper
ts *typesystem.TypeSystem
ds storage.RelationshipTupleReader
End()
Begin(ctx Context, req ResolveCheckRequest) chan usersetMessage
}
class recursiveTTUObjectProvider {
ts *typesystem.TypeSystem
tuplesetRelation string
computedRelation string
pool *pool.ContextPool
End()
Begin(ctx Context, req ResolveCheckRequest) chan usersetMessage
}
objectProvider <|-- recursiveObjectProvider : implements
objectProvider <|-- recursiveTTUObjectProvider : implements
note for recursiveObjectProvider "Replaces simpleRecursiveObjectProvider"
note for recursiveTTUObjectProvider "Replaces complexRecursiveTTUObjectProvider"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
🚨 gitStream Monthly Automation Limit Reached 🚨 Your organization has exceeded the number of pull requests allowed for automation with gitStream. To continue automating your PR workflows and unlock additional features, please contact LinearB. |
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by Sourcery
Bug Fixes:
enable-check-optimizationsflag was enabled.