-
-
Notifications
You must be signed in to change notification settings - Fork 141
Address feedback from PR 761 #762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Turns out the maintainers know their codebase better than I do - who knew! Per reviewer feedback, this reverts some overly ambitious changes from PR 761 while keeping the essential cloud storage fix that resolves the 'Key not found in database' error. Specific changes based on comments: - Restore LevelDB operations for backwards compatibility (cbartondock's suggestion) - Revert to v2.5.29 category naming with simple base64 encoding - Remove category fallback logic - users intentionally add uncategorized games (kencinder's point) - Keep cloud storage namespace detection and writing for modern Steam The result: works with both old and new Steam, doesn't make assumptions about user intent.
|
The added check for Steam running appears to be too much "catch all" if I'm not mistaken, I'm no programmer but I assume any process that includes See attached image from a user in Discord, the path in that process belongs to Emudeck and isn't Steam running from what I can tell.
Also see #764 |
|
This mechanism appears untouched since fbcd52a9. I'll take a look - this appears to be checking which processes have Steam's files open rather than checking if Steam itself is running. This would mean ANYTHING (Decky plugins etc.) reading those files would prevent SRM from executing. I believe this is why some folks have issues and others don't. I'll update this PR with an upgraded check shortly. |
Changes: - Reorder final success notification to appear AFTER Steam restart completes - Increase notification timeout from 3s to 8s for long batch operations - Add proper Observable unsubscription to prevent stray notifications - Add doNotAppendToLog flag to Steam restart notification
|
See if the build I just pushed behaves any better |
|
Error is still happening (in my case under mac, linux and windows are fine now). It is flagging the following processes: _coreaudiod 342 0.0 0.0 33798944 2964 ?? Ss 12:03PM 0:00.83 Core Audio Driver (SteamStreamingSpeakers.driver) |
Thanks for this, will take a look |

Turns out the maintainers know their codebase better than I do - who knew!
Per reviewer feedback, this reverts some overly ambitious changes from PR 761 while keeping the essential cloud storage fix that resolves the 'Key not found in database' error.
Specific changes based on comments:
The result: works with both old and new Steam, doesn't make assumptions about user intent.