Skip to content

Conversation

@smank
Copy link
Contributor

@smank smank commented Oct 5, 2025

Turns out the maintainers know their codebase better than I do - who knew!

Per reviewer feedback, this reverts some overly ambitious changes from PR 761 while keeping the essential cloud storage fix that resolves the 'Key not found in database' error.

Specific changes based on comments:

  • Restore LevelDB operations for backwards compatibility (cbartondock's suggestion)
  • Revert to v2.5.29 category naming with simple base64 encoding
  • Remove category fallback logic - users intentionally add uncategorized games (kencinder's point)
  • Keep cloud storage namespace detection and writing for modern Steam

The result: works with both old and new Steam, doesn't make assumptions about user intent.

Turns out the maintainers know their codebase better than I do - who knew!

Per reviewer feedback, this reverts some overly ambitious changes from PR 761 while keeping the essential cloud storage fix that resolves the 'Key not found in database' error.

Specific changes based on comments:
- Restore LevelDB operations for backwards compatibility (cbartondock's suggestion)
- Revert to v2.5.29 category naming with simple base64 encoding
- Remove category fallback logic - users intentionally add uncategorized games (kencinder's point)
- Keep cloud storage namespace detection and writing for modern Steam

The result: works with both old and new Steam, doesn't make assumptions about user intent.
@kencinder
Copy link
Collaborator

kencinder commented Oct 5, 2025

The added check for Steam running appears to be too much "catch all" if I'm not mistaken, I'm no programmer but I assume any process that includes steam as per https://github.com/SteamGridDB/steam-rom-manager/blob/master/src/lib/category-manager.ts#L62 would trigger SRM to think Steam is still running.

See attached image from a user in Discord, the path in that process belongs to Emudeck and isn't Steam running from what I can tell.

image

Also see #764

@smank
Copy link
Contributor Author

smank commented Oct 6, 2025

This mechanism appears untouched since fbcd52a9. I'll take a look - this appears to be checking which processes have Steam's files open rather than checking if Steam itself is running. This would mean ANYTHING (Decky plugins etc.) reading those files would prevent SRM from executing. I believe this is why some folks have issues and others don't.

I'll update this PR with an upgraded check shortly.

Changes:
- Reorder final success notification to appear AFTER Steam restart completes
- Increase notification timeout from 3s to 8s for long batch operations
- Add proper Observable unsubscription to prevent stray notifications
- Add doNotAppendToLog flag to Steam restart notification
@smank
Copy link
Contributor Author

smank commented Oct 11, 2025

See if the build I just pushed behaves any better

@doZennn doZennn requested a review from cbartondock October 12, 2025 22:37
@xfechx
Copy link

xfechx commented Oct 14, 2025

Error is still happening (in my case under mac, linux and windows are fine now). It is flagging the following processes:

_coreaudiod 342 0.0 0.0 33798944 2964 ?? Ss 12:03PM 0:00.83 Core Audio Driver (SteamStreamingSpeakers.driver)
_coreaudiod 338 0.0 0.0 33798944 2964 ?? Ss 12:03PM 0:00.85 Core Audio Driver (SteamStreamingMicrophone.driver)
fech 2107 0.0 0.0 34130696 1304 ?? S 12:43PM 0:00.01 /Users/fech/Library/Application Support/Steam/Steam.AppBundle/Steam/Contents/MacOS/ipcserver

@smank
Copy link
Contributor Author

smank commented Oct 14, 2025

Error is still happening (in my case under mac, linux and windows are fine now). It is flagging the following processes:

_coreaudiod 342 0.0 0.0 33798944 2964 ?? Ss 12:03PM 0:00.83 Core Audio Driver (SteamStreamingSpeakers.driver) _coreaudiod 338 0.0 0.0 33798944 2964 ?? Ss 12:03PM 0:00.85 Core Audio Driver (SteamStreamingMicrophone.driver) fech 2107 0.0 0.0 34130696 1304 ?? S 12:43PM 0:00.01 /Users/fech/Library/Application Support/Steam/Steam.AppBundle/Steam/Contents/MacOS/ipcserver

Thanks for this, will take a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants