Bundles messed up when the primary output depends on bundled modules #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the primary output depends on some of the modules that are gonna be bundled in an external file, dependencies get messed out and the bundles are not constructed as expected.
Example Gulpfile:
All the modules have no dependencies, except for
mainwhich depends on all the other modules.The output of the above configuration is:
main.jscontaining all the modules and the configurationfirst-bundle.jswhich is emptysecond-bundle.jswhich is emptyWith this patch, the output is as expected:
main.jscontainingmain-only-module,mainand the configurationfirst-bundle.jscontainingfirst-bundle-module1andfirst-bundle-module2second-bundle.jscontainingsecond-bundle-module1andsecond-bundle-module2