-
Notifications
You must be signed in to change notification settings - Fork 45
QoL Updates #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
IS4Code
wants to merge
49
commits into
SteveSandersonMS:main
Choose a base branch
from
IS4Code:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
QoL Updates #20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tried to update this project a bit to make it more convenient to build APIs for. There were several changes, fixes etc.
IsolatedObjectand other remote objects implementIDisposable,IEquatable, and similar, controlling the existence of their remote counterpart in memory (only the handles are disposed/compared ‒ if the remote object implementsIDisposableorIEquatableitself, it is not called).ToStringis implemented as well, but is actually routed to the remote object'sToStringimplementation.IsolatedClassand abstractIsolatedMemberfor better reflection.IsolatedObjectcan be cast back and forth betweenIsolatedMemberfor runtime members inheriting fromMemberInfo.IsolatedMethodcan be invoked with an arbitrary number of arguments. Exceptions from within the call are serialized back to the host (I am however unsure if messagepack's deserialization ofExceptioncould be potentially dangerous).IsolatedMethodcan be invoked with anIsolatedObjectargument, or any remote object (such asIsolatedMethodbeing represented asMethodInfoin the guest).IsolatedMethodcan be abstract or virtual, resolving to the proper concrete method when invoked on anIsolatedObject.IsolatedMethodcan be looked up using its full signature (as offered by Mono).IsolatedMethodsupports generic instantiation.nullinstead of an exception if not found.IBufferWriter‒IsolatedAllocator, which handles reallocations of guest memory and automatically does length-prefixing.