feat(routes-f): add devices recap drops and chapters endpoints#510
Merged
feat(routes-f): add devices recap drops and chapters endpoints#510
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@CMI-James Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented a single
routes-fdelivery for all four requested issues: push notification devices, stream recap summaries, stream drops/giveaways, and live stream chapter markers.Closes #482
Closes #484
Closes #485
Closes #486
Changes proposed
What were you told to do?
Implement all four standalone
routes-fendpoints and ship them together as one PR, pushed to upstream dev:What did I do?
Push notification devices (
#486)GETandPOSTinapp/api/routes-f/devices/route.ts.DELETEinapp/api/routes-f/devices/[id]/route.ts.Stream recap summary (
#482)GET /api/routes-f/stream/recap?stream_id=inapp/api/routes-f/stream/recap/route.ts.Cache-Control: public, max-age=86400.Drops and giveaways (
#485)GETandPOSTinapp/api/routes-f/drops/route.ts.POST /api/routes-f/drops/[id]/enter.POST /api/routes-f/drops/[id]/draw.crypto.getRandomValues.Live stream chapter markers (
#484)GETandPOSTinapp/api/routes-f/stream/chapters/route.ts.DELETEinapp/api/routes-f/stream/chapters/[id]/route.ts.timestamp_seconds <= current elapsed stream time.Hook-required type fix on dev branch
app/api/routes-f/leaderboard/route.tsto satisfy strict type-check ondev.Check List (Check all the applicable boxes)
Screenshots / Testing Evidence
npm run buildpassed (includesnpm run type-checkand production Next build)npm test -- --runInBandpassed (28 suites, 282 tests)--no-verifynot used)