Skip to content

Bugfix: Wrong assignment pin pad #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix: Wrong assignment pin pad #33

wants to merge 2 commits into from

Conversation

@andistorm
Copy link
Collaborator

@andistorm andistorm commented Nov 6, 2024

Changes

  • Change USB-C connector symbol to a 6-pin variant
  • Update PCB from Schematics

Related

@andistorm andistorm mentioned this pull request Nov 6, 2024
Open
@fschrempf
Copy link
Contributor

fschrempf commented Nov 6, 2024

Two thoughts:

  • If we already touch the USB connector what about updating it in a way that the data pins can be used (see Use USB Pins for programming #8 (comment))
  • Your update seems to remove the OSHW logo from the PCB (happens when syncing with schematic). Maybe we can add a symbol in the schematic to prevent this, or there is some way to exclude it from the sync (I'm not a KiCad expert).

@andistorm andistorm marked this pull request as draft November 6, 2024 21:42
@andistorm
Copy link
Collaborator Author

andistorm commented Nov 6, 2024

Converted to draft, since I accidently removed the OSHW logo, thanks @fschrempf for pointing this out!

@andistorm
Change USB_C_Plug symbol to Connector:USB_C_Receptacle_PowerOnly_6P
aac3416 
The used footprint is 6-pin, so the symbol should have 6 pins to

Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm
Update PCB from schematic
71601ee 
fixes pad <-> pin assignment

Signed-off-by: Andreas Heinrich <[email protected]>
@andistorm andistorm force-pushed the bugfix/wrong-assignment-pin-pad branch from d9fc8d3 to 71601ee Compare November 6, 2024 22:14
@andistorm andistorm marked this pull request as ready for review November 6, 2024 22:15
@andistorm
Copy link
Collaborator Author

andistorm commented Nov 6, 2024

OSHW logo should be back again. @fschrempf, could you double check, please?

@fschrempf
Copy link
Contributor

fschrempf commented Nov 7, 2024

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing footprint for USB C Connector

2 participants

@andistorm @fschrempf