Open
Conversation
jrz371
requested changes
Aug 23, 2021
Contributor
Author
|
I don't know much about the mac side of things. Good to know, thanks! |
jrz371
requested changes
Aug 23, 2021
Collaborator
jrz371
left a comment
jrz371
left a comment
There was a problem hiding this comment.
I think the biggest fix is making that for loop that gathers the material indices more coherent and understandable.
Contributor
Author
|
Just letting you know that I found a problem that needs a bit longer to fix. |
Contributor
Author
|
In my opinion this is good to go. Let me know if there is anything else! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge materials on layer or object level.
Merge the default material.
This is to make the gltf more compact and organized.
Current behavior is that every object gets its own material if options.UseDisplayColorForUnsetMaterials is enabled; exceptions is sub-objects with different colors.
If options.ExportLayers is also enabled the layer color gets its own material for all (sub-)objects that are set to layer color.
The DefaultMaterial.RenderMaterial was giving different guids each call so i set it to 0.