lsp: URI/Path handling fixes #1419
Merged
+51
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anderseknert
approved these changes
Feb 25, 2025
internal/lsp/uri/uri.go
Outdated
| if client == clients.IdentifierVSCode { | ||
| // Convert Windows path separators to Unix separators | ||
| path = filepath.ToSlash(path) | ||
| drivePattern := regexp.MustCompile(`^([A-Za-z]):`) |
There was a problem hiding this comment.
Let's make this a package level var to avoid it being compiled with each call.
internal/lsp/uri/uri.go
Outdated
| if strings.Contains(path, ":") || strings.Contains(path, "%3A") { | ||
| path = strings.Replace(path, "%3A", ":", 1) | ||
| path = strings.TrimPrefix(path, "/") | ||
| drivePattern := regexp.MustCompile(`^([A-Za-z])(%3[aA]|:)`) |
charlieegan3
force-pushed
the
uri-fix
branch
from
b109577 to
6088d79
Compare
|
Thanks, that makes sense! Have fixed now. |
There was an issue where a colon in a file name would cause the wrong path to be generated from a URI and vice versa. This caused the server to reload the file every second as it was missing, but really it was just registered under the wrong URI in the cache. Signed-off-by: Charlie Egan <[email protected]>
charlieegan3
force-pushed
the
uri-fix
branch
from
6475f1f to
9ce9c72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where a colon in a file name would cause the wrong path to be generated from a URI and vice versa. This caused the server to reload the file every second as it was missing, but really it was just registered under the wrong URI in the cache.