fix: add Dragonfly compatibility for Lua scripts #507
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds compatibility with Dragonfly - a Redis-compatible in-memory store. Two issues are addressed:
Dragonfly requires all keys accessed in Lua scripts to be declared upfront in the
KEYSarray, or the script must explicitly opt out using the--!df flags=allow-undeclared-keysdirective.Cacheops dynamically generates conjunction keys (
conj:*) inside Lua scripts, which causes failures in Dragonfly without this flag.Related Dragonfly issues:
Dragonfly's
cjson.decodeconverts JSON integers to Lua floats, causingtostring(1)to return"1.0"instead of"1". This broke cache key matching between Python-generated keys and Lua-generated keys:Added
format_val()helper function to format integers without a decimal point.Changes:
--!df flags=allow-undeclared-keysdirective to all Lua scriptsformat_val()function to handle integer formatting consistentlyTesting:
Dragonfly:
Redis compatibility:
Tested with Redis 4.x and Redis 7.x - all tests pass:
Redis 4:
Redis 7:
Notes:
--!dfdirective is a Lua comment, so it's safely ignored by Redisformat_val()fix is defensive and works correctly on both Redis and Dragonfly