Skip to content

Upgrade from ITK 5.4.5 to ITK 5.4.6 on CI #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
N-Dekker merged 2 commits into from
May 4, 2026
Merged

Upgrade from ITK 5.4.5 to ITK 5.4.6 on CI #1436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ce0fed
COMP: Adjust ITK version check for CMake target_link_libraries GTest
N-Dekker Apr 24, 2026
2f17bc1
COMP: Upgrade from ITK v5.4.5 to ITK v5.4.6 on CI
N-Dekker Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ElastixGitHubActions.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
cxx-compiler: "g++"
libtorch-cpu-url: "https://download.pytorch.org/libtorch/cpu/libtorch-shared-with-deps-2.8.0%2Bcpu.zip"
cuda-version: "cpu"
itk-git-tag: "v5.4.5"
itk-git-tag: "v5.4.6"
cmake-build-type: "Release"
libs:
- elastix-build/bin/libelx-ANNlib.so
Expand All @@ -25,7 +25,7 @@ jobs:
cxx-compiler: "cl.exe"
libtorch-cpu-url: "https://download.pytorch.org/libtorch/cpu/libtorch-win-shared-with-deps-2.8.0%2Bcpu.zip"
cuda-version: "cpu"
itk-git-tag: "v5.4.5"
itk-git-tag: "v5.4.6"
cmake-build-type: "Release"
libs:
- elastix-build/bin/elx-ANNlib.dll
Expand All @@ -36,7 +36,7 @@ jobs:
cxx-compiler: "clang++"
libtorch-cpu-url: "https://download.pytorch.org/libtorch/cpu/libtorch-macos-arm64-2.8.0.zip"
cuda-version: "cpu"
itk-git-tag: "v5.4.5"
itk-git-tag: "v5.4.6"
cmake-build-type: "Release"
libs:
- elastix-build/bin/libelx-ANNlib.dylib
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-elastix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
libtorch-cpu-url: "https://download.pytorch.org/libtorch/cpu/libtorch-shared-with-deps-2.8.0%2Bcpu.zip"
libtorch-cuda-url: "https://download.pytorch.org/libtorch/cu128/libtorch-shared-with-deps-2.8.0%2Bcu128.zip"
cuda_toolkit_version: '12.8.0'
itk-git-tag: "v5.4.5"
itk-git-tag: "v5.4.6"
c-compiler: "gcc"
cxx-compiler: "g++"
cmake-build-type: "Release"
Expand All @@ -25,7 +25,7 @@ jobs:
libtorch-cpu-url: "https://download.pytorch.org/libtorch/cpu/libtorch-win-shared-with-deps-2.8.0%2Bcpu.zip"
libtorch-cuda-url: "https://download.pytorch.org/libtorch/cu128/libtorch-win-shared-with-deps-2.8.0%2Bcu128.zip"
cuda_toolkit_version: '12.8.0'
itk-git-tag: "v5.4.5"
itk-git-tag: "v5.4.6"
c-compiler: "cl.exe"
cxx-compiler: "cl.exe"
cmake-build-type: "Release"
Expand All @@ -36,7 +36,7 @@ jobs:
c-compiler: "clang"
cxx-compiler: "clang++"
libtorch-cpu-url: "https://download.pytorch.org/libtorch/cpu/libtorch-macos-arm64-2.8.0.zip"
itk-git-tag: "v5.4.5"
itk-git-tag: "v5.4.6"
cmake-build-type: "Release"
libs:
- elastix-build/bin/libelx-ANNlib.dylib
Expand Down
2 changes: 1 addition & 1 deletion Common/GTesting/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ target_compile_definitions(CommonGTest PRIVATE
ELX_CMAKE_CURRENT_BINARY_DIR="${CMAKE_CURRENT_BINARY_DIR}"
)

if (ITK_VERSION VERSION_LESS_EQUAL 5.4.5)
if (ITK_VERSION VERSION_LESS_EQUAL 5.4.6)
target_link_libraries(CommonGTest
GTest::GTest
GTest::Main
Expand Down
2 changes: 1 addition & 1 deletion Core/Main/GTesting/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ target_compile_definitions(ElastixLibGTest PRIVATE
_USE_MATH_DEFINES # For M_PI.
)

if (ITK_VERSION VERSION_LESS_EQUAL 5.4.5)
if (ITK_VERSION VERSION_LESS_EQUAL 5.4.6)
target_link_libraries(ElastixLibGTest
GTest::GTest
GTest::Main
Expand Down
2 changes: 1 addition & 1 deletion Testing/CI/Azure/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
variables:
ITKv5_VERSION: v5.4.5
ITKv5_VERSION: v5.4.6
ITK_GIT_URL: https://github.com/InsightSoftwareConsortium/ITK
LIBTORCH_BINARY_URL_WIN: https://download.pytorch.org/libtorch/cpu/libtorch-win-shared-with-deps-2.6.0%2Bcpu.zip
LIBTORCH_BINARY_URL_LINUX: https://download.pytorch.org/libtorch/cpu/libtorch-cxx11-abi-shared-with-deps-2.6.0%2Bcpu.zip
Expand Down
Loading