Added Builder for Snapshot #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SonarCloud Quality Gate failed. |
nscheibe
requested changes
Oct 15, 2021
| /// <summary> | ||
| /// Initializes a builder to configure the snapshot | ||
| /// </summary> | ||
| /// <param name="target"></param> |
| /// Initializes a builder to configure the snapshot | ||
| /// </summary> | ||
| /// <param name="target"></param> | ||
| /// <returns></returns> |
| /// <summary> | ||
| /// Initializes a builder to configure the snapshot | ||
| /// </summary> | ||
| /// <param name="target"></param> |
| /// Initializes a builder to configure the snapshot | ||
| /// </summary> | ||
| /// <param name="target"></param> | ||
| /// <returns></returns> |
| /// </summary> | ||
| /// <param name="configure"></param> | ||
| /// <returns></returns> | ||
| ISnapshotBuilder ConfigureOptions(Func<MatchOptions, MatchOptions> configure); |
There was a problem hiding this comment.
I think we could make this ConfigureOptions private (but we need a little refactoring then)
| /// <summary> | ||
| /// Configures the name extension | ||
| /// </summary> | ||
| /// <param name="extensions"></param> |
| /// <returns></returns> | ||
| public static ISnapshotBuilder NameExtension( | ||
| this ISnapshotBuilder builder, | ||
| string extensions) |
There was a problem hiding this comment.
This should be a params string[]
|
|
||
| /// <summary> | ||
| /// Configures the name extension. The value passed as <paramref name="extensions"/> will be | ||
| /// added to the |
| /// <summary> | ||
| /// Configures the name of this snapshot | ||
| /// </summary> | ||
| /// <param name="extensions"></param> |
| namespace Snapshooter | ||
| { | ||
| public static class SnapshotBuilderExtensions | ||
| { |
There was a problem hiding this comment.
I think we should include the extensions to the ISnapshotBuilder interface and add it to the SnapshotBuilder. Then we could make the ConfigureOptions as a protected field and we can remove it from the interface.
It would also have the advantage, that if someone checks the ISnapshotBuilder interface (which options do exists), then the person sees immediately what kind of functions are there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Builder for Snapshots