Update face auth socket - #2
Open
eshaibu wants to merge 11 commits into
Open
Conversation
eshaibu
force-pushed
the
ft_collection_config
branch
from
January 22, 2018 06:03
cdd205f to
885ad45
Compare
eshaibu
force-pushed
the
ft_collection_config
branch
from
February 2, 2018 03:19
f5431f9 to
ceaeb86
Compare
eshaibu
force-pushed
the
ft_collection_config
branch
3 times, most recently
from
April 29, 2018 01:26
35909b2 to
18b0e9f
Compare
eshaibu
force-pushed
the
ft_collection_config
branch
from
April 29, 2018 01:30
18b0e9f to
00c21df
Compare
eshaibu
force-pushed
the
ft_collection_config
branch
from
April 30, 2018 05:34
2cca206 to
da98537
Compare
adamwardecki
suggested changes
Apr 30, 2018
| const awsRekognitionClass = new Rekognition(ctx.config); | ||
| const result = await awsRekognitionClass.createCollection(collectionId); | ||
| return response.json({ collectionArn: result.CollectionArn, statusCode: result.StatusCode }); | ||
| } catch ({ ...errors }) { |
Contributor
There was a problem hiding this comment.
it you are using everything from the response object, it can be simply
catch (error) {
return response.json(error, 400);
}
| }, 400); | ||
| }); | ||
| const awsRekognitionClass = new Rekognition(ctx.config); | ||
| const result = await awsRekognitionClass.deleteCollection(collectionId); |
Contributor
There was a problem hiding this comment.
const { statusCode } = await ...
| if (err.statusCode || err.code) { | ||
| return response.json(err, err.statusCode || 400); | ||
| } | ||
| return response.json({ message: 'Authentication fail.' }, 401); |
| } | ||
| return res; | ||
| }; | ||
| const result = await awsRekognitionClass.searchFacesByImage(collectionId, image, s3Bucket, faceMatchThreshold); |
Contributor
There was a problem hiding this comment.
const { FaceMatches }
| try { | ||
| const faceIds = res.FaceRecords.map(record => record.Face.FaceId); | ||
| await awsRekognitionClass.deleteFaces(collectionId, faceIds); | ||
| return Promise.reject({ message, statusCode: 400 }); |
Contributor
Author
There was a problem hiding this comment.
I want it in outer catch
| await users.where('external_image_id', result.FaceMatches[0].Face.ExternalImageId).firstOrFail(); | ||
| return response.json({ token: user_key, username }); | ||
| } catch (err) { | ||
| if (err.statusCode || err.code) { |
Contributor
There was a problem hiding this comment.
the err.code is currently not being used in the response (same in face-register.js)
Contributor
Author
There was a problem hiding this comment.
Sometime aws error response returns with no statusCode but always with code as part of error response
| if (searchFacesResult.FaceMatches.length > 0 | ||
| && searchFacesResult.FaceMatches[0].Face.ExternalImageId === external_image_id) { | ||
| // delete the user faces index | ||
| if (searchFacesResult.FaceMatches.length > 0) { |
Contributor
There was a problem hiding this comment.
searchFacesResult.FaceMatches.length > 0 was checked in line 37
| try { | ||
| return { | ||
| Bytes: await Rekognition.convertImageToBytes(image) | ||
| Bytes: await Buffer.from(image, 'base64') |
| .then(verifyUserFaceAuthRegistered) | ||
| .catch(() => { | ||
| if (result.user_key !== token) { | ||
| return response.json({ message: 'Given credentials does not match any user account.' }, 401); |
| message: 'Face auth enabled on user account.', is_face_auth: true | ||
| }); | ||
| }; | ||
| const result = await users.where('username', username).firstOrFail(); |
Contributor
There was a problem hiding this comment.
const { user_key, face_auth } = await
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.