rTorrent: improve session saving support #5727
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit improves session saving support for rTorrent to prevent unnecessary loss of torrent files. It also increases the session saving interval from 20 minutes to 1 hour to reduce disk i/o usage with thousands of torrents. Session saving is a very intensive task that can take minutes. Torrents fail to save into session by default when added and can be lost if a crash occurs between saving intervals.
6 tasks
smaarn
reviewed
May 14, 2023
Comment on lines
+16
to
+17
| schedule2 = session_save, 1200, 3600, ((session.save)) | ||
| method.set_key = event.download.inserted, 2_save_session, ((d.save_full_session)) |
There was a problem hiding this comment.
Open question: this will only be applied on new installation and won't be applied on upgrade. Is this something we want or would we want to try to amend existing installation's configurations on upgrade ?
There was a problem hiding this comment.
Yes, session saving could present challenges for NAS environments. It highly possible to consume more resources writing session files with torrent information to disk than actually seeding torrents. RAID 5 in particular is very suspectable to this issue.
This and the potential to lose torrents is why I would recommend amending existing installs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit improves session saving support for rTorrent to prevent unnecessary loss of torrent files. It also increases the session saving interval from 20 minutes to 1 hour to reduce disk i/o usage with thousands of torrents. Session saving is a very intensive task that can take minutes. Torrents fail to save into session by default when added and can be lost if a crash occurs between saving intervals. These two fixes improve the performance and stability of the rTorrent client.
Checklist
all-supportedcompleted successfullyType of change