Skip to content

Conversation

@wesleyboar
Copy link
Member

@wesleyboar wesleyboar commented Mar 1, 2024

Overview

Update to newer release of https://github.com/TACC/Core-Styles.

Related

Changes

  • table redesign — reverted in v2.25.1
  • button fix
  • tag padding tweak
  • <hr> fixes

Testing

  1. View/Add a table. View on narrow screen. Verify it looks CMS table.

    Sample Markup
    <table>
      <thead>
        <tr>
          <th>Sample</th>
          <th>Table</th>
        </tr>
      </thead>
      <tbody>
        <tr>
          <td>and</td>
          <td>some</td>
        </tr>
        <tr>
          <td>sample</td>
          <td>data</td>
        </tr>
      </tbody>
    </table>
  2. View/Add a button with less text and wide width. Verify text is centered.

    Sample Markup
    <button class="c-button c-button--type-primary c-button--width-long">Button</button>
  3. View/Add a tag. Verify it has padding of 0.25rem 0.5rem 0rem (source).

    Sample Markup
    <span class="c-tag c-tag--feature">Tag</span>
  4. View/Add an <hr>. Verify it does not have width: 100%.

    Sample Markup
    <hr />

UI

button hr
button hr
table tag
table tag

- table redesign
- button fix
- tag padding tweak
- `<hr>` fixes
@wesleyboar wesleyboar changed the title feat: @tacc/core-styles v2.25.0 feat: @tacc/core-styles v2.25 Mar 1, 2024
@wesleyboar wesleyboar marked this pull request as ready for review March 2, 2024 01:10
@wesleyboar wesleyboar merged commit 863131f into main Mar 2, 2024
@wesleyboar wesleyboar deleted the feat/update-core-styles-version branch March 2, 2024 01:10
@wesleyboar wesleyboar changed the title feat: @tacc/core-styles v2.25 fix: @tacc/core-styles v2.25 Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants