Skip to content

Conversation

@wesleyboar
Copy link
Member

Overview

Fix CSS specificity bug by not loading docs stylesheet in project layer.

Related

Changes

  • changed layer in which to import docs styles

Testing

  1. I tested this change on branch at task/tup-534 Adds in media query for tables #275 (comment).
  2. I skimmed all the Docs and "… (Docs)" patterns. They didn't look obviously wrong.

UI

Skipped. I accept all blame.

Notes

I want to use layers. I think clients are the correct use case.

But… I keep needing to return client stylesheet imports to base layer to fix demo bugs.

I want to use layers. I think clients are the correct use case.

But… I keep needing to return client stylesheet imports to base layer to fix demo bugs.
@github-actions github-actions bot added the fix Fixes user-facing behavior or feature label Jan 25, 2024
@wesleyboar wesleyboar changed the title fix: load docs on base, like other clients fix: load docs in base layer, like other clients Jan 25, 2024
@wesleyboar wesleyboar added the patch A backward-compatible fix label Jan 25, 2024
@wesleyboar wesleyboar merged commit 726b2a9 into main Jan 25, 2024
@wesleyboar wesleyboar deleted the fix/docs-in-project-layer-causes-list-bug-in-tup-534-tables branch January 25, 2024 20:13
@wesleyboar wesleyboar changed the title fix: load docs in base layer, like other clients fix: import docs in base layer, like other clients Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fixes user-facing behavior or feature patch A backward-compatible fix

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants