fix: form patterns bugs found via tup UI #91
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: - add MuiTab use case to bootstrap.modal - add MuiTab stylesheet for portal - remove outdated icon trump files - add base stylesheets for clients to load Client should always load base.css first. | stylesheet | root¹ | cms² | portal³ | header ⁴ | | - | - | - | - | - | | base.css | ✓ | — | — | — | | base.cms.css | — | ✓ | — | — | | base.portal.css | — | — | ✓ | — | | base.header.css | — | — | — | ✓ | There may be a base.docs.css after TUP-264. ¹ everything except cms, portal, and header ² e.g. cms ³ e.g. cepv2, tup-ui ⁴ e.g. cms, cepv2, frontera-tech-docs
| stylesheet | root¹ | cms² | portal³ | header ⁴ | | - | - | - | - | - | | core-styles.base.css | ✓ | — | — | — | | core-styles.cms.css | — | ✓ | — | — | | core-styles.portal.css | — | — | ✓ | — | | core-styles.header.css | — | — | — | ✓ | There may be a core-styles.docs.css after TUP-264. ¹ everything except cms, portal, and header ² e.g. cms ³ e.g. cepv2, tup-ui ⁴ e.g. cms, cepv2, frontera-tech-docs
With layers, core-styles.header.css must overwrite core-styles.cms.css. Sans layers, site.header.css relied on bootstrap to override site.css.
Avoid dupllicate custom property (a.k.a. variable) definitions in: - `.core-styles.cms.css` - `.core-styles.header.css`
- some changes may be for main branch - some changes may be for task/base-cms-portal-header branch 1. testing pattern for Core-CMS djangco.cms.forms 2. new c-form component & pattern needs template 3. just begining form.cms pattern 4. update s-affixed-input-… accordingly (for: 2, 3) 4. initial change of partials to use core-styles.*.css
- some changes may be for main branch - some changes may be for task/base-cms-portal-header branch 1. testing pattern for Core-CMS djangco.cms.forms 2. new c-form component & pattern needs template 3. just begining form.cms pattern 4. update s-affixed-input-… accordingly (for: 2, 3) 4. initial change of partials to use core-styles.*.css
This is for CMS, but was being tested here. it works now. Latest real bug was misssing the .html extension inthe demo. This pattern was just committed in TACC/Core-CMS: - task/get-core-styles-beyond-0.11.0 - d13ca50 I am porting the polishes and fixes here just so that when I delete I am deleting at the time at which CMS resumes control of it.
- build - removed import of settings by src/_imports files - added `core-styles.settings.css` - changed demo to always load `core-styles.settings.css` up front BREAKING CHANGE: Clients must include `settings.css` OR `base.css` e.g. - @import url('@tacc/core-styles/dist/core-styles.settings.css') - @import url('@tacc/core-styles/dist/core-styles.base.css')
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
This update fixes bug where layer() was not retained on @import rules!
This caused broken styles in CMS. The alpha solution was re-evaluated last week. It will be rolled back.
…nto dev--task/form-patterns--task/base-cms-portal-header--bugfix/form-patterns-bugs-found-via-tup-ui
…l-header--bugfix/form-patterns-bugs-found-via-tup-ui
wesleyboar
changed the title
wesleyboar
added
fix
wesleyboar
force-pushed
the
bugfix/form-patterns-bugs-found-via-tup-ui
branch
from
84af835 to
dea152f
Compare
This merge mostyl takes incoming changes (from main) because so many fixes to form have come since this branch was given a PR: https://github.com/TACC/Core-Styles/pulls?q=is%3Apr+is%3Amerged+form+merged%3A2022-12-14..2025-02-17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix various Form pattern bugs (found in TACC/tup-ui).
Status
Related
…Changes
…
Testing
UI
…