refactor: manage external articles without snippet #529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyboar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
External articles can be managed automatically via script. Snippet unnecessary.
Note
Snippets have already been deleted on prod in favor of the new script, loaded via CDN. But, review welcome to improve/revise solution.
Related
Changes
news/open-external-post.htmlredirect.htmlad-hoc/external-articles.jsad-hoc.jsTesting
Visit news page that has external article e.g.
which has article Investing in the Future of Texas.
Verify link of Investing in the Future of Texas opens article on different website.
Visit that TACC news article: https://tacc.utexas.edu/news/latest-news/2024/05/06/K5-training/
Verify article redirects to: https://weteachcs.org/news/latest-news/2024/05/06/K5-training/
UI
open.in.new.site.mov
redirect.mov
Notes
After TUP CMS has TACC/Core-CMS#1033, I will delete this new script here.
This is all still a solution that assumes user has JavaScript enabled. Ideally, a server-side solution is implemented instead.