-
Notifications
You must be signed in to change notification settings - Fork 4
[Feat] 이용약관 및 개인정보처리방침 모달, 페이지 구현 #162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
d7e19f3
feat: 온보딩 페이지 이용약관 문구 UI 추가 (#159)
odukong 2b90d5a
feat: 온보딩 유효성 검사 로직, 동의항목 추가 (#159)
odukong 235820f
refactor: 모달 크기(width, height)를 커스텀하기 위한 size 속성 추가 (#159)
odukong 4a403e8
design: 모달 X 버튼 사이즈 수정 (#159)
odukong 2a2fb47
feat: 이용약관 텍스트 데이터 생성 (#159)
odukong 405f84b
feat: 이용약관 모달 UI 구현 (#159)
odukong 7ba628d
refactor: 이용약관&개인정보처리방침 모달 컨텐츠 공유를 위한 Content 컴포넌트 분리 (#159)
odukong 4ad1dda
feat: 개인정보처리방침 UI 구현 (#159)
odukong 4e6ad76
feat: 이용약관&개인정보처리방침 페이지 UI 구현 (#159)
odukong aa3002f
refactor: policypage 중복 코드 제거 (#159)
odukong 3eb508f
fix: 코드래빗 수정사항 반영 (#159)
odukong 421908a
design: 개인정보처리방침 페이지 gap 수정 (#159)
odukong dd9b4f9
refactor: 체크박스 이벤트와 약관 모달 이벤트 분리 (#159)
odukong 2ff1fc6
design: 모달 컴포넌트 박스 영역 반응형 적용 (#159)
odukong 06667ad
fix: 누락된 key 추가 (#159)
odukong 0f6e5dd
refactor: 약관 모달 조건부 렌더링 로직을 객체 매핑 방식으로 개선 (#159)
odukong 4658aea
design: 모달 아이콘 추가 (#159)
odukong 6919883
design: medium 버튼 텍스트 크기 body_m_14로 변경 (#159)
odukong b246e98
design: Modal css 수정사항 반영 (#159)
odukong 6649060
refactor: Modal css수정에 따른 코드 수정 (#159)
odukong 7b0c65a
design: 코드래빗 수정사항 반영 (#159)
odukong ad92565
design: 모달 텍스트 띄어쓰기 추가 (#159)
odukong 7d20951
fix: 카카오로그인 로직 수정 및 리프레쉬 토큰 오류 해결 (#159)
odukong c563804
Merge branch 'dev' into feat/#159/onboarding-agree-modal
odukong 9a94bbd
fix: 빌드 에러 해결 (#159)
odukong e50c4b5
fix: ai-report 생성 중복 요청 에러 해결 (#159)
odukong File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모달 버튼 의미와 XButton 동작 간 불일치 가능성이 있어요.
onClose에confirmLeave(나가기)를,onConfirm에cancelLeave(계속 작성)를 매핑한 것은 버튼 라벨과 일치하지만,Modal.XButton클릭 시 동작이 예상과 다를 수 있어요.modal-provider.tsx에서Modal의onClose는modalStore.close(modal.id)만 호출해요. 이 경우:blocker.state가 여전히"blocked"상태useEffect가 다시 트리거되어 모달이 재오픈됨기능적으로는 작동하지만, 사용자가 XButton으로 모달을 닫으려 할 때 즉시 다시 열리는 UX가 혼란스러울 수 있어요. XButton을 숨기거나, 명시적으로 "계속 작성하기" 동작과 연결하는 것을 고려해 보세요.
🤖 Prompt for AI Agents