Skip to content

Report THEOlive events to Conviva #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 3, 2025
Merged

Report THEOlive events to Conviva #68

merged 8 commits into from
Oct 3, 2025

Conversation

@tvanlaerhoven
Copy link
Member

@tvanlaerhoven tvanlaerhoven commented Jul 30, 2025 •
edited by MattiasBuelens
Loading

❗This PR needs the CurrentSourceChange events from Android SDK 10.2+

Added:

  • reporting of the current source's encoding_type, either "DASH", "HLS" or "HESP".
  • reporting of THEOlive's intentToFallback reason.
  • reporting of THEOlive's endpoint cdn through Conviva.defaultResource.
  • THEOlive demo source.

tvanlaerhoven
tvanlaerhoven commented Jul 30, 2025
View reviewed changes
MattiasBuelens
MattiasBuelens reviewed Jul 30, 2025
View reviewed changes
@tvanlaerhoven tvanlaerhoven marked this pull request as draft July 31, 2025 08:33
@tvanlaerhoven
Copy link
Member Author

tvanlaerhoven commented Jul 31, 2025

Converted to draft: there's an issue with order of events on the player SDK.

@tvanlaerhoven tvanlaerhoven force-pushed the feature/conviva/theolive-reporter branch 3 times, most recently from d5c62ef to 7c8d05e Compare September 23, 2025 13:50
@MattiasBuelens MattiasBuelens changed the title Feature/conviva/theolive reporter Report THEOlive events to Conviva Sep 23, 2025
@MattiasBuelens MattiasBuelens added the 🔌 connector: conviva Affects the Conviva connector label Sep 23, 2025
@tvanlaerhoven tvanlaerhoven force-pushed the feature/conviva/theolive-reporter branch 2 times, most recently from b95febd to f80806c Compare September 29, 2025 09:00
@tvanlaerhoven tvanlaerhoven marked this pull request as ready for review September 29, 2025 09:17
@tvanlaerhoven tvanlaerhoven force-pushed the feature/conviva/theolive-reporter branch from f80806c to 09f4133 Compare September 29, 2025 13:35
@tvanlaerhoven tvanlaerhoven force-pushed the feature/conviva/theolive-reporter branch from 4f8e385 to 4284af9 Compare September 30, 2025 09:13
MattiasBuelens
MattiasBuelens approved these changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@MattiasBuelens MattiasBuelens left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but (as already mentioned) we first have to wait for the 10.2.0 SDK release.

@tvanlaerhoven tvanlaerhoven merged commit c1b2a86 into master Oct 3, 2025
1 check failed
@tvanlaerhoven tvanlaerhoven deleted the feature/conviva/theolive-reporter branch October 3, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MattiasBuelens MattiasBuelens MattiasBuelens approved these changes

@OlegRyz OlegRyz Awaiting requested review from OlegRyz

Assignees

No one assigned

Labels

🔌 connector: conviva Affects the Conviva connector

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tvanlaerhoven @MattiasBuelens