Skip to content

Commit

Permalink
AMBW-46748
Browse files Browse the repository at this point in the history
[Maven] Profile value is not updated in 'generate pom.xml' once user deploys application using 'external profile'/ 'other profile' option
  • Loading branch information
richardyam-tibco committed Sep 22, 2022
1 parent a06c037 commit 4ba38a4
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,10 @@ public void addAndDeployApplication(final String domainName, final String appSpa
}
log.info("Deploying the Application with name -> " + appName + " with Profile -> " + profile);
deployApplication(domainName, appSpaceName, earName, path, startOndeploy, replace, profile,externalProfile,appDescription);
if(externalProfile){
// fix from runtime side only
// UI doesn't seem to fix the externalProfile flag when profile is set to an application Profile
// We should use the external profile here if this is really the case
if(externalProfile && !externalProfileLoc.isEmpty() && (profile != null && profile.equals("other")) ) {
setProfile(domainName,appSpaceName,version,appName,externalProfileLoc);
log.info("Starting Application -> "+ appName);
if(startOndeploy){
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,10 @@ private boolean validateFields() {
}

boolean isValidexternalProfileLoc = true;
if(externalProfile && externalProfileLoc.isEmpty()) {
// fix from runtime side only
// UI doesn't seem to fix the externalProfile flag when profile is set to an application Profile
// We should give error only if profile is set to "other" and not an interal application profile
if(externalProfile && externalProfileLoc.isEmpty() && (profile != null && profile.equals("other")) ) {
isValidexternalProfileLoc = false;
errorMessage.append("[external Profile Location value is required]");
}
Expand Down

0 comments on commit 4ba38a4

Please sign in to comment.