Skip to content

Support different gnomad files for mutect2 and pileup #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

LKress
Copy link
Contributor

@LKress LKress commented Jun 14, 2024

  • Separate gnomad files for germline filtering in MUTECT2 (gnomad_af_only_hg38) and contamination estimation in PILEUP_SUMMARIES (small_exac_common_3) to avoid Java heap out of memory error

@LKress LKress requested a review from priesgo June 14, 2024 07:41
@priesgo priesgo marked this pull request as ready for review June 14, 2024 09:33
Copy link
Collaborator

@priesgo priesgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is looking good.

The help message in nextflow.config has to be updated.

@priesgo
Copy link
Collaborator

priesgo commented Jun 14, 2024

I suspect for the tests to pass, you may need to merge the latest merged PR from master into this branch, as it updated to Java 11.

@priesgo
Copy link
Collaborator

priesgo commented Jun 14, 2024

It would be a good moment to update all GATK dependencies. Also, if I remember right, there were two similar, but still different GATK versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants