840 short description for each video by karjo24 · Pull Request #1510 · TUM-Dev/gocast

karjo24 · 2025-03-08T14:22:42Z

Motivation and Context

#840. Having the ability to make short notes or add/change the title of the lecture is useful for organising lectures when titles are not provided by the course admins.

Description

There's an additional option in the dropdown menu for each stream on the course overview page that allows users to input their own (limited to 80 characters) lecture title. There's a new API endpoint, that takes the new title and stores it in a new table in the database.

Steps for Testing

Prerequisites:

1 User
1 Course with 1 stream with title, 1 stream without

Log in and navigate to course
Click on the "More options" menu (three dots next to stream)
Click on "Edit personal lecture title"
Enter new title in popup menu
Verify the following behaviour
5.1 Pressing "Enter" or clicking outside the input field changes the title
5.2 Pressing "Escape" disregards any changes
5.3 Deleting the value of the input field resets the title to the actual title provided by the lecturer
Reload to make sure the changes are persistent

Screenshots

Screencast.from.2025-03-08.15-19-45.mp4

carlobortolan

Tested it locally and it looks good to me 👍

Just two more general questions:

Should the personal lecture title be displayed only in the course-view, or also in the "Recent VODs" and videoplayer/stream-view?
Should lecturers/admins of a course be allowed to add personal lecture titles, or would it be better to have the button set the actual lecture title to avoid confusion?

karjo24 · 2025-03-09T21:17:51Z

* Should the personal lecture title be displayed only in the course-view, or also in the "Recent VODs" and videoplayer/stream-view?

Yes, thanks for catching that. Somehow thought the title was not displayed there and didn't check. I'll change that.

* Should lecturers/admins of a course be allowed to add personal lecture titles, or would it be better to have the button set the actual lecture title to avoid confusion?

It probably shouldn't be left like this as I agree with the confusion part. I'm not sure, whether we should hide the menu option for admins or make it change the title globally. After all, that's what the admin page is for. I lean towards the "hide it"-approach, but I'm open for other opinions.

carlobortolan · 2025-03-11T13:18:57Z

It probably shouldn't be left like this as I agree with the confusion part. I'm not sure, whether we should hide the menu option for admins or make it change the title globally. After all, that's what the admin page is for. I lean towards the "hide it"-approach, but I'm open for other opinions.

I think we can leave it out for now and add it in the future in a separate PR if necessary.

joschahenningsen

Pretty nice! Left just a few comments

joschahenningsen · 2025-03-12T09:01:59Z

+// Upsert updates the entry if it exists, inserts it else
+func (d userDefinedLectureTitlesDao) Upsert(userLectureTitle *model.UserDefinedLectureTitle) error {
+	return d.db.Save(userLectureTitle).Error
+}


Do we need upserting? With user_id and stream_id being composite primary keys, we can use create with a conflict clause to update a record. See e.g.

gocast/dao/progress.go

Line 58 in fe0190d

err2 = DB.Clauses(clause.OnConflict{

I would go that way and rename the method to Save and drop Create and Upsert

joschahenningsen · 2025-03-12T09:04:00Z

+	if len(s.CustomLectureTitles) > 0 {
+		customLectureName = s.CustomLectureTitles[0].Title
+	}


What exactly is happening here? We just use the first title? Wouldn't we send a random users title to someone?

Although this isn't set to a random users title, this should definitely be changed, yes, Idk what I was thinking. It wasn't set to a random title, because the CustomLectureTitles in this PR only get preloaded in conjunction with a Where clause, that checks the userId.

It is now fixed. However, is there a cleaner way using Gorm to achieve the same to avoid having to add it manually afterwards?

joschahenningsen · 2025-03-12T09:05:01Z

+// BeforeCreate is a GORM hook that is called before a new user is created.
+// UserDefinedLectureTitle will not be saved if the title is too long
+func (u *UserDefinedLectureTitle) BeforeCreate(tx *gorm.DB) (err error) {
+	if len(u.Title) > 256 {


Can you trim the whitespace? https://pkg.go.dev/strings#TrimSpace

Is there any particular reason for this? Wouldn't this lead to a title being falsely accepted by BeforeCreate and then failing Save, if #whitespace + #meaningfulLetters > 256, but #meaningfulLetters < 256? Is this a best practice I'm not aware of?

Added strings.TrimSpace in both the model's BeforeCreate hook (model/lecture_titles.go) and in the API handler (api/stream.go) before the empty-check, so whitespace-only titles are correctly treated as a delete/reset. Commit: 681b37a.

…bugs

SebiWrn · 2025-03-18T16:04:44Z

Maybe there should also be a button for the user to delete the custom title, as just removing it to reset it to the lecturers title may not be intuitive.

karjo24 · 2025-03-21T10:42:55Z

Should the personal lecture title be displayed only in the course-view, or also in the "Recent VODs" and videoplayer/stream-view?

Yes, thanks for catching that. Somehow thought the title was not displayed there and didn't check. I'll change that.

I'd postpone this change as this would require changing the signature of two methods, which are heavily used throughout the project, which would inflate this PR.

alexanderstephan · 2026-04-27T19:58:57Z

@copilot resolve the merge conflicts in this pull request.

Agent-Logs-Url: https://github.com/TUM-Dev/gocast/sessions/3e52aecf-8cbc-4bde-a8dc-d086283d8439 Co-authored-by: alexanderstephan <30267166+alexanderstephan@users.noreply.github.com>

Copilot · 2026-04-27T20:05:45Z

@copilot resolve the merge conflicts in this pull request.

Merge conflicts were already resolved in commit 56f1acd (Merge branch 'dev' into 840-short-decription-for-each-video). The branch is currently up to date.

karjo24 added 12 commits March 5, 2025 17:17

button for personal lecture title change

7fb318d

frontend structure

ae9ff7e

removed readonly

bc4ffe7

database base setup of new table

6844ab7

cleaned up dao, added updateorcreate

022bd59

extended backend to include custom lecture naem

b1f2927

query fix

c539464

frontend includes customName, only api missing

b8cc26d

renamed function

f28bf72

added api

3f3c4f1

added api call

55ab7b2

fixed wrong cache setting

b936700

karjo24 linked an issue Mar 8, 2025 that may be closed by this pull request

Short Decription for each video #840

Open

karjo24 self-assigned this Mar 8, 2025

karjo24 added 4 commits March 8, 2025 15:27

fixed eslint suggestions

5c6635e

adapted tests to changes of this PR; Eslint fix

d6d7cc4

golang lint fix

9f9ddf3

golang linter fix

4030e72

karjo24 requested a review from a team March 8, 2025 15:07

deletes personal lecture name when set to empty string

134ebc4

carlobortolan reviewed Mar 9, 2025

View reviewed changes

Comment thread api/courses.go Outdated

Comment thread dao/courses.go Outdated

Comment thread web/template/home.gohtml Outdated

carlobortolan and others added 4 commits March 9, 2025 03:14

Add custom lecture title to apiv2.proto

365a89b

shorter menu entry title for conciseness

b29498b

refactored two getCourseBySlugYearAndTerm[User] into one

3b5e4c6

changed tests to match new function signature

c580b9d

carlobortolan added the enhancement New feature or request label Mar 11, 2025

joschahenningsen reviewed Mar 12, 2025

View reviewed changes

code style changes

a5d2661

karjo24 and others added 5 commits March 14, 2025 17:04

refactored upsert to save using clauses

0185dee

changed file name and edited error message to reflect prior changes

5e51dfb

changed where lecture title gets added to stream DTO to avoid future …

6170ef2

…bugs

changed cache key to avoid collisions

076e788

Merge branch 'dev' into 840-short-decription-for-each-video

56f1acd

karjo24 requested a review from joschahenningsen March 14, 2025 17:30

karjo24 mentioned this pull request Mar 14, 2025

Bump meilisearch-go #1519

Closed

karjo24 removed the request for review from joschahenningsen March 17, 2025 16:31

karjo24 added 2 commits March 21, 2025 11:47

incorrect redirect removed

c2239a1

eslint fix

c923a00

SebiWrn changed the title ~~840 short decription for each video~~ 840 short description for each video Apr 30, 2025

joschahenningsen self-requested a review May 9, 2025 11:15

Copilot started work on behalf of alexanderstephan April 27, 2026 19:59 View session

Trim whitespace from custom lecture title before saving

681b37a

Agent-Logs-Url: https://github.com/TUM-Dev/gocast/sessions/3e52aecf-8cbc-4bde-a8dc-d086283d8439 Co-authored-by: alexanderstephan <30267166+alexanderstephan@users.noreply.github.com>

Copilot finished work on behalf of alexanderstephan April 27, 2026 20:06

Copilot AI requested a review from alexanderstephan April 27, 2026 20:06

Conversation

karjo24 commented Mar 8, 2025

Motivation and Context

Description

Steps for Testing

Screenshots

Uh oh!

carlobortolan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

karjo24 commented Mar 9, 2025

Uh oh!

carlobortolan commented Mar 11, 2025

Uh oh!

joschahenningsen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joschahenningsen Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

karjo24 Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

joschahenningsen Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

karjo24 Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

karjo24 Mar 14, 2025

Choose a reason for hiding this comment

Uh oh!

joschahenningsen Mar 12, 2025

Choose a reason for hiding this comment

Uh oh!

karjo24 Mar 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

SebiWrn commented Mar 18, 2025

Uh oh!

karjo24 commented Mar 21, 2025

Uh oh!

alexanderstephan commented Apr 27, 2026

Uh oh!

Copilot AI commented Apr 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

karjo24 Mar 14, 2025 •

edited

Loading