Enh/add reactions by SebiWrn · Pull Request #1565 · TUM-Dev/gocast

SebiWrn · 2025-04-17T14:17:59Z

Motivation and Context

This pull request adds previously mentioned reactions by students (look at #1564).
Closes #127.

The percentage below the reactions shows the usage in the last few minutes.

Available reactions can be modified in the config.yaml.

Important

Do not merge before #1564 !!

Screenshots

kordianbruck · 2025-06-05T08:12:27Z

+			CustomMessage: "user not eligible to watch course",
+		})
+		return
+	}


optional: these three conditionals seem like they could be a separate function that could be reused?

I will leave them there for now and they can be extracted if we need them somewhere else

kordianbruck · 2025-06-05T08:14:19Z

+	go func() {
+		// Notify admins every 5 seconds
+		logger.Info("Starting periodic notification of reaction percentages")
+		for {


Isn't this a leaking goroutine? You never end it or cancel it via a context?

This should be ok as this is only started once at the initialize and it will be stopped when the program stops.

alexanderstephan · 2026-04-18T11:25:11Z

@copilot resolve the merge conflicts in this pull request

# Conflicts: # tools/config.go # web/template/watch.gohtml Co-authored-by: alexanderstephan <30267166+alexanderstephan@users.noreply.github.com>

Copilot · 2026-04-18T11:30:42Z

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflicts in commit 7dccd7a. Two files had conflicts:

tools/config.go: kept both AllowedReactions (from this PR) and RtmpProxyService (from dev)
web/template/watch.gohtml: merged dev's updated responsive CSS classes with this PR's reactions button and overlay, and replaced the old separate desktop chat button with dev's unified chat button

Co-authored-by: Copilot <copilot@github.com>

Copilot

Pull request overview

This PR introduces live “stream reactions” so students can submit quick emoji feedback during a livestream, and admins can see live reaction highlights plus short-window usage percentages. It also adds configuration for allowed reactions and wires the new feature into the existing watch/admin UI and realtime infrastructure.

Changes:

Add backend persistence + REST endpoints for submitting reactions and fetching allowed reactions.
Add realtime channel to push reaction events and rolling percentage updates to the live admin management page.
Add frontend UI components (watch page reaction picker overlay + admin live view visualization) and a new TS API module.

Reviewed changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 15 comments.

Show a summary per file

File	Description
web/ts/watch.ts	Adds an import related to seekbar overlay exports (currently unused).
web/ts/entry/video.ts	Exposes the new reactions TS API via the watch/video bundle exports.
web/ts/api/stream-reactions.ts	New TS API module for submitting reactions, fetching allowed reactions, and subscribing to realtime reaction updates.
web/template/watch.gohtml	Adds a reactions button + overlay on the watch page and a link to live stream management for admins.
web/template/components/stream-reactions.gohtml	New component rendering available reaction buttons driven by allowed reactions API.
web/template/admin/lecture-live-management.gohtml	Adds live reaction visualization (highlight + percentage) and modifies stream end modal request handling.
tools/config.go	Logs presence/absence of configured allowed reactions on startup.
pkg/campus/campusonline/campusonline.go	Minor import reordering cleanup.
model/stream-reaction.go	New GORM model for persisting per-user reactions per stream.
mock_dao/stream-reaction.go	New generated GoMock for the StreamReactionDao interface.
dao/stream-reaction.go	New DAO for creating/querying reactions, including time-window queries.
dao/dao_base.go	Wires StreamReactionDao into DaoWrapper.
api/stream_reactions.go	New API routes + realtime channel implementation for reactions and periodic percentage updates.
api/stream.go	Registers REST endpoints under `/api/stream/:streamID/reaction` and `/reaction/allowed`.
api/router.go	Registers the new realtime channel at startup.
cmd/tumlive/main.go	Adds StreamReaction to AutoMigrate.
config.yaml	Adds `allowedReactions` configuration with default emoji set.
api/worker_grpc.go	Removes unused helper/imports (cleanup).
go.mod	Adds `github.com/getsentry/sentry-go` dependency.
go.sum	Adds checksums for the new sentry-go dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-27T20:48:19Z

+// GetByStream gets a StreamReaction by stream within the last ... minutes.
+func (d streamReactionDao) GetByStreamWithinMinutes(c context.Context, streamID uint, minutes uint) (res []model.StreamReaction, err error) {
+	time_specified := time.Now().Add(-time.Duration(minutes) * time.Minute)
+	return res, d.db.WithContext(c).Where("stream_id = ? AND created_at > ?", streamID, time_specified.String()).Find(&res).Error


created_at > ? is parameterized with time_specified.String(), which turns the timestamp into a string. This can lead to incorrect comparisons depending on the DB/driver. Pass the time.Time value directly so GORM can bind it as a proper timestamp.

Suggested change

return res, d.db.WithContext(c).Where("stream_id = ? AND created_at > ?", streamID, time_specified.String()).Find(&res).Error

return res, d.db.WithContext(c).Where("stream_id = ? AND created_at > ?", streamID, time_specified).Find(&res).Error

Copilot · 2026-04-27T20:48:19Z

+        await Realtime.get().subscribeChannel("reaction-update", this.handle);
+        await Realtime.get().send("reaction-update", {
+            type: RealtimeMessageTypes.RealtimeMessageTypeChannelMessage,
+            payload: { streamID: streamId },


The realtime message payload uses streamID, but the backend unmarshals streamId (lowercase d). With this mismatch the admin websocket session won’t get associated to a stream, so updates won’t arrive. Align the JSON field name between client and server.

Suggested change

payload: { streamID: streamId },

payload: { streamId: streamId },

Copilot · 2026-04-27T20:48:20Z

+	for _, session := range liveReactionListener {
+		streams = append(streams, session.stream)
+	}
+	liveReactionListenerMutex.Unlock()


This early Unlock() combined with the deferred unlock at the top of the function can cause a panic on any early return before the mutex is re-locked. Refactor to avoid mixing a deferred unlock with manual unlock/re-lock in the same function.

Copilot · 2026-04-27T20:48:20Z

+	stream, err := daoWrapper.StreamsDao.GetStreamByID(context.TODO(), messageObj.StreamID)
+	if err != nil {
+		logger.Error("Cant get stream by id", "err", err)
+		return
+	}


This code relies on the package-level daoWrapper variable (set by a different realtime channel in api/runner.go). That creates a hidden dependency on registration order and makes this channel fragile. Pass the DaoWrapper into RegisterReactionUpdateRealtimeChannel and store it in a dedicated variable for reactions instead of reusing the runner global.

Copilot · 2026-04-27T20:48:20Z

+func (r StreamReactionRoutes) addReaction(c *gin.Context) {
+	tumLiveContext := c.MustGet("TUMLiveContext").(tools.TUMLiveContext)
+	user := tumLiveContext.User
+	stream := tumLiveContext.Stream
+


New reactions endpoints and realtime update logic are introduced here, but there are no accompanying tests. Given the repo’s existing API test coverage, please add tests for allowed reactions, disallowed reactions, cooldown behavior, and permission checks.

Copilot · 2026-04-27T20:48:22Z

+	if user == nil || err != nil {
+		_ = c.Error(tools.RequestError{
+			Status:        http.StatusInternalServerError,
+			CustomMessage: "user or course not found",


If user is nil, this returns a 500 "user or course not found" even though it’s an authentication/authorization issue. Split the checks so missing user returns 401/403, and reserve 500 for actual server-side failures (e.g., course lookup errors).

Suggested change

if user == nil || err != nil {

_ = c.Error(tools.RequestError{

Status: http.StatusInternalServerError,

CustomMessage: "user or course not found",

if user == nil {

_ = c.Error(tools.RequestError{

Status: http.StatusUnauthorized,

CustomMessage: "user not authenticated",

})

return

}

if err != nil {

_ = c.Error(tools.RequestError{

Status: http.StatusInternalServerError,

CustomMessage: "course lookup failed",

Err: err,

Copilot · 2026-04-27T20:48:22Z

                        <button class="bg-green-500 inline-block text-center w-24 text-white hover:bg-green-600 dark:hover:bg-green-600 font-bold rounded cursor-pointer p-1 mr-3"
-                                @click="fetch(`/api/stream/${streamID}/end?discard=${false}`).then((response) => {if (response.ok) showModal=false; else throw new Error('Response not ok');}).catch((err) => {
-                                            console.log('Some error occurred while ending the stream:', err);
-                                        });">
+                                @click="fetch(`/api/stream/${streamID}/end?discard=${false}`).then(showModal=false)">
                            Yes


fetch(...).then(showModal=false) assigns showModal immediately and passes a boolean to .then(), so the modal closes regardless of request success and response errors are ignored (the same pattern is repeated on the "No" button). Use a callback in .then(...) and ideally check response.ok like before.

Copilot · 2026-04-27T20:48:22Z

+	type Message struct {
+		StreamID string `json:"streamId"`
+	}
+
+	var messageObj Message


The server expects streamId in the message payload (json:"streamId"), but the client currently sends streamID. With the current mismatch messageObj.StreamID will be empty and stream lookup will fail. Update either the JSON tag or the client payload key so they match.

Copilot · 2026-04-27T20:48:22Z

+	lastReaction, _ := r.DaoWrapper.StreamReactionDao.GetLastReactionOfUser(c, user.ID)
+	// This contains the cooldown logic, to change this value change the time.Duration(10) to the desired cooldown time
+	if lastReaction.Reaction != "" && lastReaction.CreatedAt.Add(time.Duration(10)*time.Second).After(time.Now()) {
+		_ = c.Error(tools.RequestError{
+			Status:        http.StatusTooManyRequests,


Cooldown is enforced using GetLastReactionOfUser(user.ID) without filtering by stream. This means a reaction in one stream can block reactions in another stream during the cooldown window. Consider looking up the last reaction per (user, stream) so cooldown is applied per stream.

Copilot · 2026-04-27T20:48:22Z

+	"github.com/TUM-Dev/gocast/model"
+)
+
+//go:generate mockgen -source=streamReaction.go -destination ../mock_dao/streamReaction.go


The go:generate directive references streamReaction.go / ../mock_dao/streamReaction.go, but this file is stream-reaction.go and the generated mock in this PR is mock_dao/stream-reaction.go. As written, go generate ./... won’t reproduce/update this mock. Update the directive (source + destination) to match the actual filenames/paths used in the repo.

Suggested change

//go:generate mockgen -source=streamReaction.go -destination ../mock_dao/streamReaction.go

//go:generate mockgen -source=stream-reaction.go -destination ../mock_dao/stream-reaction.go

SebiWrn requested a review from a team April 17, 2025 14:17

SebiWrn self-assigned this Apr 17, 2025

SebiWrn linked an issue Apr 17, 2025 that may be closed by this pull request

Live reactions for lectures #127

Closed

kordianbruck requested changes Jun 5, 2025

View reviewed changes

SebiWrn mentioned this pull request Jun 18, 2025

Enh/live admin view #1564

Merged

SebiWrn added 25 commits October 16, 2025 09:08

Added additional management page

6d4277b

Added livestream and course/lecture name to management page

f16b1b2

Added Video Stats

e10d5b9

Added stats and parts of the chat

bcafd91

Changed text color of stats

bfefdc3

Moved chat to the right

8e57dee

Fixed chat and added Seek to Live Button

fff7704

Fixed layout of seek button

94d51c9

Added function to use highest quality

d9a9261

Minor fixes

3eed1a9

Added highest quality automatically and added Remaining live time

c06c2f8

Added current time to lecture live page

ec6e2a3

Added reactions to model and added endpoints to add reactions

e0d0722

Added reactions to watch page

878fec4

Removed reactions from lecture-management

1597514

Renamed stream reactions

e45b5c4

Added stream reaction websocket

c92b347

Added functionality to send reaction to admin

e69c80e

Added admin check

07da05b

Fixed kernel panic

d2e10c9

Added reactions to typescript

7408bbd

Reactions now show up on admin panel

dabe712

Fixed opacity bug

d803fb2

Added percentage to the reactions in admin screen

bec3075

Added todo

7dcd7de

SebiWrn added 15 commits October 16, 2025 09:13

Some minor design changes

e602b32

Removed debugging information

5a25136

Live lecture management page is only usable if stream is live

1d39bf0

Changed chat layout

3f52e95

Added Restart and Stop button for stream

4c02557

Some minor changes

b905cdb

eslint fix

b3b6957

Fixed watch.ts

f84d02a

eslint fix 2

297bd09

eslint fix

09733ab

Gofumpted

ddaab5b

Some lint fixes

377084f

Small api change so gocast does not crash

a6c16d7

Some fixes

c4d58b1

Minor fixes after merge

9d4356f

SebiWrn force-pushed the enh/add-reactions branch from 24c748f to 9d4356f Compare October 16, 2025 07:23

golangci-lint

8fbd965

SebiWrn requested a review from a team October 16, 2025 07:41

Copilot started work on behalf of alexanderstephan April 18, 2026 11:25 View session

Merge remote-tracking branch 'origin/dev' into enh/add-reactions

7dccd7a

# Conflicts: # tools/config.go # web/template/watch.gohtml Co-authored-by: alexanderstephan <30267166+alexanderstephan@users.noreply.github.com>

Copilot finished work on behalf of alexanderstephan April 18, 2026 11:31

Copilot AI requested a review from alexanderstephan April 18, 2026 11:31

alexanderstephan and others added 3 commits April 27, 2026 22:16

Fix linter issues

f760136

Co-authored-by: Copilot <copilot@github.com>

Merge remote-tracking branch 'origin/dev' into enh/add-reactions

e6f6ef0

Add missing dep

03f419d

alexanderstephan requested a review from Copilot April 27, 2026 20:39

Copilot started reviewing on behalf of alexanderstephan April 27, 2026 20:40 View session

Copilot AI reviewed Apr 27, 2026

View reviewed changes

	return res, d.db.WithContext(c).Where("stream_id = ? AND created_at > ?", streamID, time_specified.String()).Find(&res).Error
	return res, d.db.WithContext(c).Where("stream_id = ? AND created_at > ?", streamID, time_specified).Find(&res).Error

	payload: { streamID: streamId },
	payload: { streamId: streamId },

	//go:generate mockgen -source=streamReaction.go -destination ../mock_dao/streamReaction.go
	//go:generate mockgen -source=stream-reaction.go -destination ../mock_dao/stream-reaction.go

Conversation

SebiWrn commented Apr 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Motivation and Context

Screenshots

Uh oh!

Uh oh!

Uh oh!

kordianbruck Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

SebiWrn Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

kordianbruck Jun 5, 2025

Choose a reason for hiding this comment

Uh oh!

SebiWrn Jun 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

alexanderstephan commented Apr 18, 2026

Uh oh!

Copilot AI commented Apr 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

SebiWrn commented Apr 17, 2025 •

edited

Loading